Skip to content

Commit

Permalink
[PATCH] mm: page_alloc cleanups
Browse files Browse the repository at this point in the history
Small cleanups that does not change generated code with the gcc's I've tested
with.

Signed-off-by: Nick Piggin <npiggin@suse.de>
Cc: Hugh Dickins <hugh@veritas.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
Nick Piggin authored and Linus Torvalds committed Jan 6, 2006
1 parent a86b1f5 commit 085cc7d
Showing 1 changed file with 6 additions and 10 deletions.
16 changes: 6 additions & 10 deletions mm/page_alloc.c
Original file line number Diff line number Diff line change
Expand Up @@ -447,8 +447,7 @@ void __free_pages_ok(struct page *page, unsigned int order)
*
* -- wli
*/
static inline struct page *
expand(struct zone *zone, struct page *page,
static inline void expand(struct zone *zone, struct page *page,
int low, int high, struct free_area *area)
{
unsigned long size = 1 << high;
Expand All @@ -462,7 +461,6 @@ expand(struct zone *zone, struct page *page,
area->nr_free++;
set_page_order(&page[size], high);
}
return page;
}

/*
Expand Down Expand Up @@ -522,7 +520,8 @@ static struct page *__rmqueue(struct zone *zone, unsigned int order)
rmv_page_order(page);
area->nr_free--;
zone->free_pages -= 1UL << order;
return expand(zone, page, order, current_order, area);
expand(zone, page, order, current_order, area);
return page;
}

return NULL;
Expand All @@ -537,19 +536,16 @@ static int rmqueue_bulk(struct zone *zone, unsigned int order,
unsigned long count, struct list_head *list)
{
int i;
int allocated = 0;
struct page *page;

spin_lock(&zone->lock);
for (i = 0; i < count; ++i) {
page = __rmqueue(zone, order);
if (page == NULL)
struct page *page = __rmqueue(zone, order);
if (unlikely(page == NULL))
break;
allocated++;
list_add_tail(&page->lru, list);
}
spin_unlock(&zone->lock);
return allocated;
return i;
}

#ifdef CONFIG_NUMA
Expand Down

0 comments on commit 085cc7d

Please sign in to comment.