Skip to content

Commit

Permalink
[ARM] pxa: avoid registering multiple pxa2xx_pcmcia devices
Browse files Browse the repository at this point in the history
cm_x270 and mainstone both register their PCMCIA devices using the same
name, resulting in a warning message from the kernel.  Avoid this by
making the cm_x270 and mainstone PCMCIA initialisation conditional on
the machine type we're running on.

Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
  • Loading branch information
Russell King authored and Russell King committed Jun 2, 2008
1 parent 720046d commit 04ba0f6
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 0 deletions.
4 changes: 4 additions & 0 deletions drivers/pcmcia/pxa2xx_cm_x270.c
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@

#include <pcmcia/ss.h>
#include <asm/hardware.h>
#include <asm/mach-types.h>

#include <asm/arch/pxa-regs.h>
#include <asm/arch/pxa2xx-gpio.h>
Expand Down Expand Up @@ -147,6 +148,9 @@ static int __init cmx270_pcmcia_init(void)
{
int ret;

if (!machine_is_armcore())
return -ENODEV;

cmx270_pcmcia_device = platform_device_alloc("pxa2xx-pcmcia", -1);

if (!cmx270_pcmcia_device)
Expand Down
4 changes: 4 additions & 0 deletions drivers/pcmcia/pxa2xx_mainstone.c
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
#include <pcmcia/ss.h>

#include <asm/hardware.h>
#include <asm/mach-types.h>
#include <asm/irq.h>

#include <asm/arch/pxa-regs.h>
Expand Down Expand Up @@ -153,6 +154,9 @@ static int __init mst_pcmcia_init(void)
{
int ret;

if (!machine_is_mainstone())
return -ENODEV;

mst_pcmcia_device = platform_device_alloc("pxa2xx-pcmcia", -1);
if (!mst_pcmcia_device)
return -ENOMEM;
Expand Down

0 comments on commit 04ba0f6

Please sign in to comment.