Skip to content

Update test_results.py #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update test_results.py #1

wants to merge 1 commit into from

Conversation

kaiyaok2
Copy link
Owner

@kaiyaok2 kaiyaok2 commented Mar 5, 2025

What does this PR do?

Fixes #xxx

The test tests/tests_pytorch/core/test_results.py::test_result_reduce_ddp fails intermittently due to chance, similar to the one addressed in #20537, with the error:

torch.multiprocessing.spawn.ProcessExitedException: process 0 terminated with signal SIGABRT

To address this, the test should also be marked flaky.

Background

We are researchers working on test case prioritization and have integrated our tool into GitHub CI. During a CI run for commit 7322d63bef2cf1a0439f8b19b545cd4a89da62b0, we encountered this failure. You can find the logs here: GitHub Actions Log.

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you verify new and existing tests pass locally with your changes?

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@kaiyaok2 kaiyaok2 added the bug Something isn't working label Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant