Skip to content

Commit

Permalink
test: fix generateImages script to not read .base64 files etc (fix fi…
Browse files Browse the repository at this point in the history
…le ending regex) (opensheetmusicdisplay#676)

only affects visual regression tests basically. (npm run generate:blessed, npm run test:visual:build, etc)
  • Loading branch information
sschmidTU committed May 14, 2024
1 parent 57b3acf commit b158698
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions test/Util/generateImages_browserless.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -199,15 +199,15 @@ async function init () {

const sampleDirFilenames = FS.readdirSync(sampleDir);
let samplesToProcess = []; // samples we want to process/generate pngs of, excluding the filtered out files/filenames
const fileEndingRegex = "^.*(([.]xml)|([.]musicxml)|([.]mxl))$";
for (const sampleFilename of sampleDirFilenames) {
if (osmdTestingMode && filterRegex === "allSmall") {
if (sampleFilename.match("^(Actor)|(Gounod)")) { // TODO maybe filter by file size instead
debug("filtering big file: " + sampleFilename, DEBUG);
continue;
}
}
// eslint-disable-next-line no-useless-escape
if (sampleFilename.match("^.*(\.xml)|(\.musicxml)|(\.mxl)$")) {
if (sampleFilename.match(fileEndingRegex)) {
// debug('found musicxml/mxl: ' + sampleFilename)
samplesToProcess.push(sampleFilename);
} else {
Expand All @@ -218,7 +218,7 @@ async function init () {
// filter samples to process by regex if given
if (filterRegex && filterRegex !== "" && filterRegex !== "all" && !(osmdTestingMode && filterRegex === "allSmall")) {
debug("filtering samples for regex: " + filterRegex, DEBUG);
samplesToProcess = samplesToProcess.filter((filename) => filename.match(filterRegex));
samplesToProcess = samplesToProcess.filter((filename) => filename.match(filterRegex) && filename.match(fileEndingRegex));
debug(`found ${samplesToProcess.length} matches: `, DEBUG);
for (let i = 0; i < samplesToProcess.length; i++) {
debug(samplesToProcess[i], DEBUG);
Expand Down

0 comments on commit b158698

Please sign in to comment.