Skip to content

Conversation

@arekbulski
Copy link
Member

Additional check when reading bytes, requesting negative amount should cause error. Construct has this check too.

@arekbulski arekbulski requested a review from GreyCat January 19, 2018 12:47
@GreyCat GreyCat merged commit 160ac27 into master Jan 19, 2018
@GreyCat
Copy link
Member

GreyCat commented Jan 19, 2018

Makes sense, thanks! I thought that Python's stream read would have this check, but instead it works something like negative array indexes or something like that.

@arekbulski arekbulski deleted the patch-readbytes branch January 31, 2018 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants