Fix for applyForEach implementation on BigQueueImpl when gc is called #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 11, 2022 17:53
…s called on the bigQueue, this.innerArray.size() used in the iterator will not work. This is due to the gc() method changing this.arrayTailIndex on BigArrayImpl to a value before the pointer to the front of the queue. applyForEach assumes that this.arrayTailIndex on BigArrayImpl will always be 0, which is not correct.
…s called on the bigQueue, this.innerArray.size() used in the iterator will not work. This is due to the gc() method changing this.arrayTailIndex on BigArrayImpl to a value before the pointer to the front of the queue. applyForEach assumes that this.arrayTailIndex on BigArrayImpl will always be 0, which is not correct.
|
Nice pull request, very well done. Not sure why you commented out the removeAll at the bottom of the test though. I'm going to manually merge this into the develop branch and then release a new version. |
brianhks
added a commit
that referenced
this pull request
Oct 13, 2022
|
Created 1.0.3 version with this fix. |
|
@brianhks I accidently did that. I readded it back on in a later commit. |
|
Hey! @brianhks can you please help with newer version of BigQueue that you have mentioned above. I see only 0.7.0 is available on maven repo. |
|
https://search.maven.org/artifact/org.kairosdb/bigqueue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@brianhks - I see that you have been maintaining the bigqueue repo, so I thought i raise and fix an issue that we have been experiencing.
We are currently using the old implementation from the bulldog project.
We noticed an issue with the applyForEach implementation in the BigQueueImpl class whereby if you action a gc(), it changes the scope of the data in the BigArrayImpl that is not consider for the applyForEach method.
I have created a new test for this, if you run this this on the current implemention it will fail and if you walk though the test, you can see that it should be working. A small fix for this has been made.
Please consider this as a patch.