🐛 Create journald persistent path #1324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Journald will not save any logs to disk if it finds that there is no /var/log/journal directory created (wut?) so make sure to create the dir during initramfs stage so the logs are persisted across reboots Signed-off-by: Itxaka <itxaka.garcia@spectrocloud.com>
Itxaka
changed the title
✅ Deploy Preview for kairos-io canceled.
|
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #1324 +/- ##
==========================================
- Coverage 22.79% 21.10% -1.69%
==========================================
Files 22 16 -6
Lines 1610 1284 -326
==========================================
- Hits 367 271 -96
+ Misses 1179 962 -217
+ Partials 64 51 -13
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
mudler
approved these changes
Apr 19, 2023
|
Good catch! I'm guessing if this instead should be a .keep file in our overlay, but dynamically seems much better, so we detect the OS instead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Journald will not save any logs to disk if it finds that there is no /var/log/journal directory created (wut?) so make sure to create the dir during initramfs stage so the logs are persisted across reboots
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #597