✨ Custom partitioning refactor config #1180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for kairos-io canceled.
|
mauromorales
force-pushed
the
209-custom-partitioning-refactor-config
branch
from
4143874
to
ab0895e
Compare
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #1180 +/- ##
==========================================
- Coverage 22.79% 22.07% -0.73%
==========================================
Files 22 16 -6
Lines 1610 1282 -328
==========================================
- Hits 367 283 -84
+ Misses 1179 950 -229
+ Partials 64 49 -15
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
mauromorales
changed the title
jimmykarily
reviewed
Mar 24, 2023
jimmykarily
reviewed
Mar 24, 2023
jimmykarily
reviewed
Mar 24, 2023
jimmykarily
reviewed
Mar 24, 2023
jimmykarily
previously approved these changes
Mar 24, 2023
jimmykarily
reviewed
Mar 27, 2023
to split the collection of config sources out of the config package. Each consumer of the new package will take care of unmarshalling the yaml to a specific Config struct, do validations etc. Signed-off-by: Dimitris Karakasilis <dimitris@spectrocloud.com> Signed-off-by: Mauro Morales <mauro.morales@spectrocloud.com>
Signed-off-by: Mauro Morales <mauro.morales@spectrocloud.com>
Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me> Signed-off-by: Mauro Morales <mauro.morales@spectrocloud.com>
Signed-off-by: Mauro Morales <mauro.morales@spectrocloud.com>
Signed-off-by: Dimitris Karakasilis <dimitris@spectrocloud.com> Signed-off-by: Mauro Morales <mauro.morales@spectrocloud.com>
to return a Config directly Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me> Signed-off-by: Mauro Morales <mauro.morales@spectrocloud.com>
Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me> Signed-off-by: Mauro Morales <mauro.morales@spectrocloud.com>
Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me> Signed-off-by: Mauro Morales <mauro.morales@spectrocloud.com>
TODO: Print a warning when a file with missing or invalid header is encountered. Will do that when we implement proper logging on the Config Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me> Signed-off-by: Mauro Morales <mauro.morales@spectrocloud.com>
Config will be specific to Kairos while Collector will be generic. This will allow us to do validations which are just related to Kairos at the config level, while including every type of key and querying of the full yaml at the Collector level splitting the responsibilities of each package. Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me> Signed-off-by: Mauro Morales <mauro.morales@spectrocloud.com>
Signed-off-by: Mauro Morales <mauro.morales@spectrocloud.com>
Signed-off-by: Mauro Morales <mauro.morales@spectrocloud.com>
Signed-off-by: Mauro Morales <mauro.morales@spectrocloud.com>
Signed-off-by: Mauro Morales <mauro.morales@spectrocloud.com>
Signed-off-by: Mauro Morales <mauro.morales@spectrocloud.com>
Signed-off-by: Mauro Morales <mauro.morales@spectrocloud.com>
Signed-off-by: Mauro Morales <mauro.morales@spectrocloud.com>
mauromorales
force-pushed
the
209-custom-partitioning-refactor-config
branch
from
9811310
to
ccf7baf
Compare
jimmykarily
approved these changes
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Needs kairos-io/kcrypt#14