Handle nvidia boards in kairos-init #229

mauromorales · 2025-10-28T12:47:44Z

Fixes #62

codecov · 2025-10-28T12:48:56Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.66%. Comparing base (30cd29e) to head (8d497f5).

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #229   +/-   ##
=======================================
  Coverage   66.66%   66.66%           
=======================================
  Files           1        1           
  Lines         168      168           
=======================================
  Hits          112      112           
  Misses         39       39           
  Partials       17       17

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

- Move all NVIDIA L4T packages from NvidiaPackages to KernelPackagesModels for AgxOrin and OrinNX models - Add CUDA, Jetson GPIO, OpenCV, and NVIDIA Container Toolkit packages to kernel packages - Remove NvidiaPackages struct entirely as all packages are now kernel-related - Update GetPackages function to remove NVIDIA-specific logic - Fix cross-compilation by ensuring ARM64 packages are selected for NVIDIA models - All NVIDIA packages are now properly categorized as kernel/firmware packages

- Add command to remove existing NVIDIA repository files prior to creating the L4T packages directory in the installation stage.

- Remove hardcoded ARM64 architecture handling for NVIDIA Jetson devices. - Update logic to use the system's architecture directly when filtering kernel packages. - This change improves cross-compilation support and streamlines package retrieval.

- Introduced BasePackagesModels to define model-specific base packages for Ubuntu on ARM64 architecture. - Updated GetPackages function to include these model-specific packages when a non-generic model is specified.

…tu ARM64 - Expanded BasePackagesModels to include a new entry for AgxOrin with essential packages such as bridge-utils, efibootmgr, and vim. - This update enhances the package management for specific models, improving usability for users of the AgxOrin platform.

- Changed model checks from generic identifiers to full model names for NVIDIA Jetson devices in the installation stage. - This ensures accurate execution of commands specific to the nvidia-jetson-agx-orin and nvidia-jetson-orin-nx models.

mauromorales · 2025-10-30T20:49:18Z

pkg/stages/steps_install.go

+		// Dockerfile.nvidia-orin-nx it says 36 :shrug:, do we actually need a
+		// default or should the user always set it? if we have a default, should it
+		// ever change?
+		nvidiaRelease = "35"


@jordankrp I see that the default here is 35, but in https://github.com/kairos-io/kairos/blob/master/images/Dockerfile.nvidia-orin-nx#L11 it's 36, do you know why there's a difference?

We were in the midst of upgrading our JetPack version from L4T 35.3.1 to 36.4.4. So the former variables are probably leftovers from our initial setup. We re now using nvidiaRelease = "36" and nvidiaVersion = "4.4" which we can update here.

mauromorales · 2025-10-30T20:50:11Z

pkg/stages/steps_install.go

+		// Dockerfile.nvidia-orin-nx it says 4.4 :shrug:, do we actually need a
+		// default or should the user always set it? if we have a default, should it
+		// ever change?
+		nvidiaVersion = "3.1"


@jordankrp I see that the default here is 3.1 but in https://github.com/kairos-io/kairos/blob/c3011d352d0648df6829352a06eb9e4b96ff1892/images/Dockerfile.nvidia-orin-nx#L12 it's 4.4, do you know why there's a difference?

Same, see my comment above.

mauromorales · 2025-10-30T20:52:32Z

pkg/stages/steps_install.go

 			},
 		},
+		{
+			Name: "Setup NVIDIA L4T repositories",


@Itxaka I'm not sure if I'm doing this properly, can you validate? Basically, I'm trying to mimic the steps in https://github.com/kairos-io/kairos/blob/master/images/Dockerfile.nvidia-orin-nx but I couldn't find a way to say e.g.

rm -rf /etc/apt/sources.list.d/nvidia-l4t-apt-source.list

install base packages

set nvidia repos

install kernel packages in that order

nevertheless this seems to build, so maybe it's ok?

@jordankrp how strict does the order in that dockerfile need to be? 😅

I think the order is more about optimising docker caching when building a new OS image.

mauromorales · 2025-10-30T20:54:01Z

pkg/values/packagemaps.go

 type VersionMap map[string][]string

+// BasePackagesModels allows model-specific base packages per distro/arch/model
+var BasePackagesModels = ModelPackageMap{


@Itxaka I added these to follow a similar approach to KernelPackagesModels, but I don't understand why we have to distinguish from Generic, IMO it would be better to be able already in KernelPackages, or BasePackages to have this granularity

mauromorales · 2025-10-30T20:55:17Z

pkg/values/packagemaps.go

+					"bridge-utils",
+					"efibootmgr",
+					"fuse",
+					"git",
+					"grub2-common",
+					"libssl-dev",
+					"policykit-1",
+					"vim",


probably not all these packages are needed and probably some can be installed based on the previous stages like GrubPackages for example

Can you validate what is a must here? @mudler

I think we can remove "git" and "vim" here, but I would keep the rest as kinda of useful.

Note the list was pulled directly from the images from nvidia.

mauromorales · 2025-10-30T20:56:53Z

pkg/values/packagemaps.go

+					"bc",
+					"binutils",
+					"bluez",
+					"bridge-utils",
+					"bzip2",
+					"ca-certificates",
+					"can-utils",
+					"cloud-guest-utils",
+					"conntrack",
+					"console-data",
+					"console-setup",
+					"coreutils",
+					"cron",
+					"cryptsetup",
+					"curl",
+					"debianutils",
+					"default-jdk",
+					"dirmngr",
+					"dmsetup",
+					"dosfstools",
+					"dracut",
+					"dracut-live",
+					"dracut-network",
+					"e2fsprogs",
+					"efibootmgr",
+					"ethtool",
+					"fail2ban",
+					"fdisk",
+					"file",
+					"fuse3",
+					"gawk",
+					"gdisk",
+					"gettext",
+					"gnupg",
+					"gnupg1-l10n",
+					"gpg-agent",
+					"grub2-common",
+					"grub-efi-arm64",
+					"grub-efi-arm64-bin",
+					"grub-efi-arm64-signed",
+					"haveged",
+					"iproute2",
+					"iptables",
+					"iputils-ping",
+					"isc-dhcp-client",
+					"isc-dhcp-common",
+					"isc-dhcp-server",
+					"jq",
+					"kbd",
+					"kmod",
+					"lbzip2",
+					"less",
+					"libatm1",
+					"libglib2.0-data",
+					"libgpm2",
+					"libldap-common",
+					"libnss-systemd",
+					"libopencv-dev",
+					"libpam-cap",
+					"libqt5core5a",
+					"libsasl2-modules",
+					"libssl-dev",
+					"lldpd",
+					"logrotate",
+					"lvm2",
+					"mdadm",
+					"modemmanager",
+					"mtd-utils",
+					"nano",
+					"nbd-client",
+					"ncurses-term",
+					"netplan.io",
+					"net-tools",
+					"networkd-dispatcher",
+					"network-manager",
+					"nfs-client",
+					"nfs-common",
+					"nftables",
+					"open-iscsi",
+					"openssh-server",
+					"open-vm-tools",
+					"os-prober",
+					"packagekit-tools",
+					"parted",
+					"passwd",
+					"patch",
+					"pigz",
+					"pkg-config",
+					"policykit-1",
+					"psmisc",
+					"publicsuffix",
+					"qemu-user-static",
+					"rsync",
+					"shared-mime-info",
+					"shim-signed",
+					"snmpd",
+					"software-properties-common",
+					"squashfs-tools",
+					"ssh",
+					"sudo",
+					"systemd",
+					"systemd-container",
+					"systemd-sysv",
+					"systemd-timesyncd",
+					"tar",
+					"tpm2-tools",
+					"ubuntu-advantage-tools",
+					"udev",
+					"unzip",
+					"vim",
+					"wget",
+					"wireless-tools",
+					"wpasupplicant",
+					"xxd",
+					"xz-utils",
+					"zerofree",
+					"zfsutils-linux",
+					"zstd",


this are all the packages in https://github.com/kairos-io/kairos/blob/master/images/Dockerfile.nvidia-orin-nx I assume it can be stripped down to only the necessary ones, but I'm not sure what would those be 😅 ... I just know we probably don't need nano and vim there hehe

Opinions @jordankrp @mudler ?

Indeed this is a mix of fairly needed packages and setup-specific ones. Off the top of my head the setup-specific ones in our case (which you probably don't need here) are can-utils, default-jdk, jq, modemmanager, logrotate, zstd and parted.

Copilot

Pull Request Overview

This PR updates the naming convention for NVIDIA Jetson board models from short names (agx-orin, orin-nx) to fully qualified names (nvidia-jetson-agx-orin, nvidia-jetson-orin-nx), and adds comprehensive support for these NVIDIA boards including L4T packages, CUDA configuration, and repository setup.

Key Changes:

Renamed model constants to use fully qualified NVIDIA board names
Added extensive NVIDIA L4T and CUDA package lists for both AGX Orin and Orin NX models
Added install stage steps for NVIDIA repository setup, CUDA path configuration, and device-specific configurations
Extended CI test matrix to include NVIDIA Jetson board builds

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.

File	Description
pkg/values/values.go	Updated model constant names from short form to fully qualified NVIDIA board names
pkg/values/packagemaps.go	Added BasePackagesModels map with NVIDIA-specific packages and extensive L4T/CUDA package lists for both board types
pkg/stages/steps_install.go	Added environment variable handling for L4T/board configuration and multiple install steps for NVIDIA repository setup and device configuration
.github/workflows/test.yml	Extended test matrix to include ARM64 builds for both NVIDIA Jetson board models

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

pkg/stages/steps_install.go

mudler · 2025-10-31T08:12:17Z

pkg/values/packagemaps.go

+				},
+			},
+			OrinNX: {
+				Common: {


I think the packages are the same across all the L4T stack - would make sense to have a common piece for both the flavors (OrinNX and AGX Orin) to improve maintenance

mudler · 2025-10-31T08:13:44Z

pkg/values/packagemaps.go

+					"grub2-common",
+					"libssl-dev",
+					"policykit-1",
+					"vim",


Suggested change

"vim",

mudler · 2025-10-31T08:13:50Z

pkg/values/packagemaps.go

+					"bridge-utils",
+					"efibootmgr",
+					"fuse",
+					"git",


Suggested change

"git",

jordankrp · 2025-10-31T09:46:03Z

pkg/stages/steps_install.go

+	// Get board model from environment or config
+	boardModel := os.Getenv("BOARD_MODEL")
+	if boardModel == "" {
+		// Does it make sense that both AGX Orin and Orin NX use the same board model?


Eventually the main difference is how we flash and the partition layout, so it probably wouldn't matter to use the same at this stage, as long as the URL request later on doesn't complain.

mauromorales added 2 commits October 28, 2025 13:45

Move logic on Dockerfiles in the kairos repo here

8cc1eb8

test

aed7839

mauromorales added 5 commits October 28, 2025 14:15

Add MODEL variable to test workflow configuration

e9e5c8e

Merge branch 'main' into handle-nvidia-boards

07fc136

chore: clean up NVIDIA repository files before setup

dd76241

- Add command to remove existing NVIDIA repository files prior to creating the L4T packages directory in the installation stage.

mauromorales force-pushed the handle-nvidia-boards branch from 79c4ece to ad6357c Compare October 30, 2025 20:17

mauromorales added 7 commits October 30, 2025 21:17

add what ai removed

8586435

User boards full names

1f8991b

spaces

904401d

missing changing the models in the test.yaml

29fa43f

feat: add model-specific base packages for Ubuntu ARM64

fd4a46f

- Introduced BasePackagesModels to define model-specific base packages for Ubuntu on ARM64 architecture. - Updated GetPackages function to include these model-specific packages when a non-generic model is specified.

mauromorales commented Oct 30, 2025

View reviewed changes

mauromorales marked this pull request as ready for review October 30, 2025 20:57

mauromorales requested a review from a team as a code owner October 30, 2025 20:57

mauromorales requested review from Itxaka, Copilot and mudler October 30, 2025 20:57

Copilot AI reviewed Oct 30, 2025

View reviewed changes

mauromorales changed the title ~~[WIP] Handle nvidia boards~~ Handle nvidia boards in kairos-init Oct 30, 2025

mudler reviewed Oct 31, 2025

View reviewed changes

pkg/values/packagemaps.go

"grub2-common",

"libssl-dev",

"policykit-1",

"vim",

Copy link

Member

mudler Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

"vim",

mudler reviewed Oct 31, 2025

View reviewed changes

pkg/values/packagemaps.go

"bridge-utils",

"efibootmgr",

"fuse",

"git",

Copy link

Member

mudler Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

"git",

jordankrp reviewed Oct 31, 2025

View reviewed changes

jimmykarily added this to 🧙Issue tracking board Nov 3, 2025

jimmykarily moved this to Under review 🔍 in 🧙Issue tracking board Nov 3, 2025

Handle nvidia boards in kairos-init #229

Are you sure you want to change the base?

Handle nvidia boards in kairos-init #229

Conversation

mauromorales commented Oct 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Oct 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jordankrp Oct 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

mauromorales commented Oct 28, 2025 •

edited

Loading

codecov bot commented Oct 28, 2025 •

edited

Loading

jordankrp Oct 31, 2025 •

edited

Loading