Fix partitioner on disks with secotor size other than 512 #582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were assuming all disks in the world would have a sector size of 512 but that its not true. This patch will not force to open the disk with a hardcoded sector size and will use the sector size values of the disk to set the sizes, partition table and such. this fixes partitions on disks with 4k sector size Signed-off-by: Itxaka <itxaka@kairos.io>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #582 +/- ##
==========================================
- Coverage 49.96% 48.23% -1.74%
==========================================
Files 48 48
Lines 4657 6002 +1345
==========================================
+ Hits 2327 2895 +568
- Misses 2054 2831 +777
Partials 276 276 ☔ View full report in Codecov by Sentry. |
jimmykarily
reviewed
Oct 24, 2024
richardelling
approved these changes
Oct 28, 2024
|
can you believe I already forgot about this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were assuming all disks in the world would have a sector size of 512 but that its not true.
This patch will not force to open the disk with a hardcoded sector size and will use the sector size values of the disk to set the sizes, partition table and such.
this fixes partitions on disks with 4k sector size
Fixes kairos-io/kairos#2964