Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test and fix recovery upgrade #509

Merged
merged 8 commits into from
Sep 4, 2024

Conversation

jimmykarily
Copy link
Contributor

@jimmykarily jimmykarily commented Sep 3, 2024

Extracted from here: #508 (comment)

Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
pkg/config/spec.go Outdated Show resolved Hide resolved
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 52.10%. Comparing base (4401ced) to head (774547e).
Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
pkg/config/spec.go 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #509      +/-   ##
==========================================
- Coverage   52.13%   52.10%   -0.04%     
==========================================
  Files          52       52              
  Lines        4943     4944       +1     
==========================================
- Hits         2577     2576       -1     
- Misses       2079     2080       +1     
- Partials      287      288       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

so that we check if this works (fixed bug)

Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
@jimmykarily jimmykarily marked this pull request as ready for review September 3, 2024 12:37
@jimmykarily jimmykarily requested a review from a team September 3, 2024 12:38
@jimmykarily jimmykarily self-assigned this Sep 3, 2024
pkg/config/spec.go Outdated Show resolved Hide resolved
As described here:
https://github.com/kairos-io/kairos-agent/pull/499/files#r1735245329

the `unmarshallFullSpec` will take care of the `upgrade.entry`
config so no need to handle it twice.

Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
pkg/action/upgrade_test.go Outdated Show resolved Hide resolved
Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
@jimmykarily jimmykarily merged commit 76899b7 into main Sep 4, 2024
14 checks passed
@jimmykarily jimmykarily deleted the add-test-and-fix-recovery-upgrade branch September 4, 2024 10:22
github-actions bot referenced this pull request in kairos-io/provider-kairos Sep 4, 2024
…3.6 (#631)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[github.com/kairos-io/kairos-agent/v2](https://redirect.github.com/kairos-io/kairos-agent)
| `v2.13.4` -> `v2.13.6` |
[![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fkairos-io%2fkairos-agent%2fv2/v2.13.6?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fkairos-io%2fkairos-agent%2fv2/v2.13.6?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fkairos-io%2fkairos-agent%2fv2/v2.13.4/v2.13.6?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fkairos-io%2fkairos-agent%2fv2/v2.13.4/v2.13.6?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>kairos-io/kairos-agent
(github.com/kairos-io/kairos-agent/v2)</summary>

###
[`v2.13.6`](https://redirect.github.com/kairos-io/kairos-agent/releases/tag/v2.13.6)

[Compare
Source](https://redirect.github.com/kairos-io/kairos-agent/compare/v2.13.5...v2.13.6)

#### What's Changed

- Bump github.com/opencontainers/runc from 1.1.13 to 1.1.14 in the
go_modules group across 1 directory by
[@&#8203;dependabot](https://redirect.github.com/dependabot) in
[https://github.com/kairos-io/kairos-agent/pull/510](https://redirect.github.com/kairos-io/kairos-agent/pull/510)
- fix(deps): update module github.com/google/go-github/v63 to v64 by
[@&#8203;renovate](https://redirect.github.com/renovate) in
[https://github.com/kairos-io/kairos-agent/pull/511](https://redirect.github.com/kairos-io/kairos-agent/pull/511)
- fix(deps): update module github.com/twpayne/go-vfs/v4 to v5 by
[@&#8203;renovate](https://redirect.github.com/renovate) in
[https://github.com/kairos-io/kairos-agent/pull/512](https://redirect.github.com/kairos-io/kairos-agent/pull/512)
- fix(deps): update module github.com/google/go-github/v63 to v64 by
[@&#8203;renovate](https://redirect.github.com/renovate) in
[https://github.com/kairos-io/kairos-agent/pull/513](https://redirect.github.com/kairos-io/kairos-agent/pull/513)
- fix(deps): update module github.com/twpayne/go-vfs/v4 to v5 by
[@&#8203;renovate](https://redirect.github.com/renovate) in
[https://github.com/kairos-io/kairos-agent/pull/514](https://redirect.github.com/kairos-io/kairos-agent/pull/514)
- Add test and fix recovery upgrade by
[@&#8203;jimmykarily](https://redirect.github.com/jimmykarily) in
[https://github.com/kairos-io/kairos-agent/pull/509](https://redirect.github.com/kairos-io/kairos-agent/pull/509)

**Full Changelog**:
kairos-io/kairos-agent@v2.13.5...v2.13.6

###
[`v2.13.5`](https://redirect.github.com/kairos-io/kairos-agent/releases/tag/v2.13.5)

[Compare
Source](https://redirect.github.com/kairos-io/kairos-agent/compare/v2.13.4...v2.13.5)

#### What's Changed

- fix(deps): update module github.com/twpayne/go-vfs/v4 to v5 by
[@&#8203;renovate](https://redirect.github.com/renovate) in
[https://github.com/kairos-io/kairos-agent/pull/492](https://redirect.github.com/kairos-io/kairos-agent/pull/492)
- fix(deps): update module github.com/google/go-github/v63 to v64 by
[@&#8203;renovate](https://redirect.github.com/renovate) in
[https://github.com/kairos-io/kairos-agent/pull/493](https://redirect.github.com/kairos-io/kairos-agent/pull/493)
- fix(deps): update module github.com/twpayne/go-vfs/v4 to v5 by
[@&#8203;renovate](https://redirect.github.com/renovate) in
[https://github.com/kairos-io/kairos-agent/pull/494](https://redirect.github.com/kairos-io/kairos-agent/pull/494)
- chore(deps): update dependency cypress to v13.14.0 by
[@&#8203;renovate](https://redirect.github.com/renovate) in
[https://github.com/kairos-io/kairos-agent/pull/495](https://redirect.github.com/kairos-io/kairos-agent/pull/495)
- fix(deps): update module github.com/masterminds/semver/v3 to v3.3.0 by
[@&#8203;renovate](https://redirect.github.com/renovate) in
[https://github.com/kairos-io/kairos-agent/pull/496](https://redirect.github.com/kairos-io/kairos-agent/pull/496)
- fix(deps): update module github.com/twpayne/go-vfs/v4 to v5 by
[@&#8203;renovate](https://redirect.github.com/renovate) in
[https://github.com/kairos-io/kairos-agent/pull/498](https://redirect.github.com/kairos-io/kairos-agent/pull/498)
- fix(deps): update module github.com/google/go-github/v63 to v64 by
[@&#8203;renovate](https://redirect.github.com/renovate) in
[https://github.com/kairos-io/kairos-agent/pull/497](https://redirect.github.com/kairos-io/kairos-agent/pull/497)
- fix(deps): update module github.com/onsi/ginkgo/v2 to v2.20.2 by
[@&#8203;renovate](https://redirect.github.com/renovate) in
[https://github.com/kairos-io/kairos-agent/pull/500](https://redirect.github.com/kairos-io/kairos-agent/pull/500)
- fix(deps): update module github.com/onsi/gomega to v1.34.2 by
[@&#8203;renovate](https://redirect.github.com/renovate) in
[https://github.com/kairos-io/kairos-agent/pull/501](https://redirect.github.com/kairos-io/kairos-agent/pull/501)
- fix(deps): update module github.com/google/go-github/v63 to v64 by
[@&#8203;renovate](https://redirect.github.com/renovate) in
[https://github.com/kairos-io/kairos-agent/pull/502](https://redirect.github.com/kairos-io/kairos-agent/pull/502)
- fix(deps): update module github.com/twpayne/go-vfs/v4 to v5 by
[@&#8203;renovate](https://redirect.github.com/renovate) in
[https://github.com/kairos-io/kairos-agent/pull/503](https://redirect.github.com/kairos-io/kairos-agent/pull/503)
- chore(deps): update dependency cypress to v13.14.1 by
[@&#8203;renovate](https://redirect.github.com/renovate) in
[https://github.com/kairos-io/kairos-agent/pull/504](https://redirect.github.com/kairos-io/kairos-agent/pull/504)
- fix(deps): update module github.com/masterminds/sprig/v3 to v3.3.0 by
[@&#8203;renovate](https://redirect.github.com/renovate) in
[https://github.com/kairos-io/kairos-agent/pull/505](https://redirect.github.com/kairos-io/kairos-agent/pull/505)
- fix(deps): update module github.com/google/go-github/v63 to v64 by
[@&#8203;renovate](https://redirect.github.com/renovate) in
[https://github.com/kairos-io/kairos-agent/pull/506](https://redirect.github.com/kairos-io/kairos-agent/pull/506)
- fix(deps): update module github.com/twpayne/go-vfs/v4 to v5 by
[@&#8203;renovate](https://redirect.github.com/renovate) in
[https://github.com/kairos-io/kairos-agent/pull/507](https://redirect.github.com/kairos-io/kairos-agent/pull/507)
- Fix image size calculation on upgrade by
[@&#8203;Itxaka](https://redirect.github.com/Itxaka) in
[https://github.com/kairos-io/kairos-agent/pull/508](https://redirect.github.com/kairos-io/kairos-agent/pull/508)

**Full Changelog**:
kairos-io/kairos-agent@v2.13.4...v2.13.5

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 11pm every weekday,before 7am
every weekday,every weekend" in timezone Europe/Brussels, Automerge - At
any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend Renovate](https://mend.io/renovate/).
View the [repository job
log](https://developer.mend.io/github/kairos-io/provider-kairos).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC41OS4yIiwidXBkYXRlZEluVmVyIjoiMzguNTkuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@mudler mudler mentioned this pull request Sep 13, 2024
34 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants