Repository navigation
fix(mobile): make the question tool fit the screen and keep Submit above the keyboard - #241
Closed
lalondesteve wants to merge 1 commit into
Closed
lalondesteve wants to merge 1 commit into
lalondesteve wants to merge 1 commit into
Conversation
On phones, interactive agent questions open in a full-screen panel bound to the conversation area, so the top toolbar and workspace panels stay reachable. The panel follows the conversation bounds and the visual keyboard viewport (including non-default interface scales) so Submit stays visible when the keyboard opens, and it never auto-focuses a field. - Back and Escape minimize the question (or close an open workspace panel first) without consuming the draft; reopening keeps the answers. - The form stays mounted across minimize/reopen, so answers survive. - Opening a request does not focus the composer or raise the keyboard. - Siblings that mount in the conversation while a question is open are isolated too, and isolation is released on unmount. - The conversation root never shows a focus ring when a request hands it focus. - A failed answer keeps the draft and also shows an error toast. - A Back that closes the sidebar before minimizing a question records the sidebar state it produces on the forward entry.
lalondesteve
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes three mobile bugs in the question tool: #234, #235, #236.
On phones, interactive agent questions now open in a panel that covers the conversation area. The top toolbar and workspace panels stay reachable.
Fixes
#234, options cut off on the right: answer options and ask fieldsets now shrink to the panel width, and long text wraps instead of overflowing.
#235, keyboard opens automatically: opening a question no longer focuses the custom-answer field. Fields lost autoFocus, and on mobile the panel itself takes focus, so the question stays readable until the user taps a field.
#236, Submit hidden behind the keyboard: the panel follows the conversation bounds and the visual viewport, including non-default interface scales, so Submit stays visible while the keyboard is open.
Related behavior
Back or Escape minimizes the question without answering it. If a workspace panel is open, Back closes that panel first. An "Open request" bar reopens the question with its draft intact.
If sending an answer fails, the draft is kept and an error toast is shown, because the panel covers the in-chat error.
While the question is open, the rest of the conversation is inert, including elements that appear after it opens. The top toolbar and workspace panels stay usable.