Repository navigation
fix(notifications): list system notifications and open their session from the Notifications tab - #240
Merged
andrebrait merged 4 commits intoOct 10, 2026
Conversation
Collaborator
Author
|
Bot review companion: andrebrait#92 (identical diff). |
…n from the Notifications tab
andrebrait
force-pushed
the
fix/notification-history-open
branch
from
October 10, 2026 07:31
b982685 to
f45b7d9
Compare
andrebrait
added a commit
to andrebrait/ompweb
that referenced
this pull request
Oct 10, 2026
…en their session from the Notifications tab Squashed from origin/fix/notification-history-open (f45b7d9) onto upstream/main.
andrebrait
added a commit
to andrebrait/ompweb
that referenced
this pull request
Oct 10, 2026
…en their session from the Notifications tab Squashed from origin/fix/notification-history-open (f45b7d9) onto upstream/main.
andrebrait
added a commit
to andrebrait/ompweb
that referenced
this pull request
Oct 10, 2026
…nly pushable notification types Squashed from origin/feat/notification-read-state (9edf773) onto upstream/main. Integration fixup: drops kahme247#242's keepRead (update notices are no longer recorded), keeps kahme247#240/kahme247#242's onClick on history entries, and adapts toast.click.test.mjs to the history: true opt-in.
…story-open # Conflicts: # CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #218 and #230, which merged without two pieces the combined build relied on.
What was missing
toastHistory, so a notification shown by the OS (Settings → Notifications → system notification) disappeared once it was dismissed.onClick, and feat(notifications): desktop and mobile notifications with Web Push #218 removed the Open link, so the Notifications tab had no way to open the session an entry came from.Changes
useNotifications: record OS-shown notifications withtoastHistory.record, passing the sessiononClick.type, andpublic/sw.jspostsomp-notification-shownto open windows after showing it, whichuseNotificationsrecords the same way. A push that arrives with no omp-web tab open is still not listed, because the history is per tab and in memory.toastHistory.recordstoresonClick;toast.addpasses it through.NotificationRow: an entry withonClickopens on click or tap (not from its buttons, links, expandable text, a drag or a text selection) and on Enter when focused. Only actionable rows are focusable and show a pointer.Verification
public/sw.jsreports a shown push to every open window (run against a fake worker scope); the page records a reported push and ignores malformed messages; an OS-shown notification is listed with the right kind and opens its session; a row runs its action on click and Enter but not from the dismiss button, the expandable text or a released selection; a row without an action is inert. Reverting either production change fails a test.npm test1304/1304; typecheck and eslint clean.