chore(deps): Bump controller-runtime to 0.23.3 and k8s.io/* to 0.35.2#264
Open
pdettori wants to merge 2 commits intokagenti:mainfrom
Open
chore(deps): Bump controller-runtime to 0.23.3 and k8s.io/* to 0.35.2#264pdettori wants to merge 2 commits intokagenti:mainfrom
pdettori wants to merge 2 commits intokagenti:mainfrom
Conversation
Bundles the following dependabot PRs into a single coordinated upgrade: - sigs.k8s.io/controller-runtime 0.20.0 → 0.23.3 (kagenti#233) - k8s.io/api 0.32.0 → 0.35.2 (kagenti#230) - k8s.io/apimachinery 0.32.0 → 0.35.2 (kagenti#231) - k8s.io/client-go 0.32.0 → 0.35.2 These dependencies must be upgraded together due to version coupling. Breaking changes in controller-runtime v0.23: - WebhookManagedBy now takes the object as a second argument (generic type parameter replaces .For() chain) - Webhook validators use concrete types instead of runtime.Object - Go 1.25.0 required (toolchain auto-download supported) Source fixes: - agentcard_webhook.go: Updated WebhookManagedBy call and validator signatures to use *AgentCard concrete type - agentruntime_webhook.go: Updated WebhookManagedBy call and validator signatures to use *AgentRuntime concrete type - Removed "wrong object type" tests (type safety now enforced at compile time by generics) CI fixes: - Bump golangci-lint from v1.64.8 to v2.11.4 (v1 built with Go 1.24 cannot lint Go 1.25 code) - Migrate .golangci.yml to v2 format via `golangci-lint migrate` Assisted-By: Claude (Anthropic AI) <noreply@anthropic.com> Signed-off-by: Paolo Dettori <dettori@us.ibm.com>
pdettori
force-pushed
the
chore/bundled-k8s-controller-runtime-bump
branch
from
0f90774 to
f319243
Compare
golangci-lint-action v6 does not support golangci-lint v2.x. The error was: "invalid version string 'v2.11.4', golangci-lint v2 is not supported by golangci-lint-action v6, you must update to golangci-lint-action v7." Assisted-By: Claude (Anthropic AI) <noreply@anthropic.com> Signed-off-by: Paolo Dettori <dettori@us.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bundles three dependabot PRs (#230, #231, #233) into a single coordinated upgrade. These dependencies are version-coupled and must be upgraded together — individual PRs fail CI due to version skew.
Dependency bumps:
sigs.k8s.io/controller-runtimek8s.io/apik8s.io/apimachineryk8s.io/client-goSource fixes for controller-runtime v0.23 breaking changes:
WebhookManagedBynow takes the object as a generic type parameter (replaces.For()chain)*AgentCard,*AgentRuntime) instead ofruntime.ObjectGo version: Bumped to 1.25.0 (required by controller-runtime 0.23.x). CI uses
go-version-file: go.modso this is handled automatically.Closes #230, #231, #233
Test plan
go build ./...passes locallygo test ./...passes locally (all unit tests, excluding e2e which requires Kind)🤖 Generated with Claude Code