feat: add mcp weather tool example#8
Merged
pdettori merged 1 commit intokagenti:mainfrom May 12, 2025
Merged
Conversation
Signed-off-by: Paolo Dettori <dettori@us.ibm.com>
Ladas
added a commit
to Ladas/agent-examples
that referenced
this pull request
Feb 4, 2026
The tracing middleware cannot capture output from streaming responses. This fix calls set_span_output() in the agent's execute() method after extracting the final answer, which populates: - mlflow.spanOutputs (for MLflow Response column) - output.value (for Phoenix/OpenInference) - gen_ai.completion (for GenAI semantic conventions) Fixes Task kagenti#8: Streaming response output capture. Signed-off-by: Ladislav Smola <lsmola@redhat.com> Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Ladas
added a commit
to Ladas/agent-examples
that referenced
this pull request
Feb 4, 2026
The tracing middleware cannot capture output from streaming responses. This fix calls set_span_output() in the agent's execute() method after extracting the final answer, which populates: - mlflow.spanOutputs (for MLflow Response column) - output.value (for Phoenix/OpenInference) - gen_ai.completion (for GenAI semantic conventions) Uses trace.get_current_span() to get the active span created by the tracing middleware. Fixes Task kagenti#8: Streaming response output capture. Signed-off-by: Ladislav Smola <lsmola@redhat.com> Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Ladas
added a commit
to Ladas/agent-examples
that referenced
this pull request
Feb 6, 2026
The tracing middleware cannot capture output from streaming responses. This fix calls set_span_output() in the agent's execute() method after extracting the final answer, which populates: - mlflow.spanOutputs (for MLflow Response column) - output.value (for Phoenix/OpenInference) - gen_ai.completion (for GenAI semantic conventions) Uses trace.get_current_span() to get the active span created by the tracing middleware. Fixes Task kagenti#8: Streaming response output capture. Signed-off-by: Ladislav Smola <lsmola@redhat.com> Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> Signed-off-by: Ladislav Smola <lsmola@redhat.com>
Ladas
added a commit
to Ladas/agent-examples
that referenced
this pull request
Feb 12, 2026
The tracing middleware cannot capture output from streaming responses. This fix calls set_span_output() in the agent's execute() method after extracting the final answer, which populates: - mlflow.spanOutputs (for MLflow Response column) - output.value (for Phoenix/OpenInference) - gen_ai.completion (for GenAI semantic conventions) Uses trace.get_current_span() to get the active span created by the tracing middleware. Fixes Task kagenti#8: Streaming response output capture. Signed-off-by: Ladislav Smola <lsmola@redhat.com> Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> Signed-off-by: Ladislav Smola <lsmola@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.