Conversation
kellyaa
force-pushed
the
slack_researcher
branch
from
28a8a50 to
163fd7a
Compare
Signed-off-by: Kelly Abuelsaad <kna@us.ibm.com> Signed-off-by: Kelly Abuelsaad <kaymar@gmail.com>
Signed-off-by: Kelly Abuelsaad <kna@us.ibm.com> Signed-off-by: Kelly Abuelsaad <kaymar@gmail.com>
Signed-off-by: Kelly Abuelsaad <kna@us.ibm.com> Signed-off-by: Kelly Abuelsaad <kaymar@gmail.com>
Signed-off-by: Kelly Abuelsaad <kna@us.ibm.com> Signed-off-by: Kelly Abuelsaad <kaymar@gmail.com>
Signed-off-by: Kelly Abuelsaad <kna@us.ibm.com> Signed-off-by: Kelly Abuelsaad <kaymar@gmail.com>
Signed-off-by: Kelly Abuelsaad <kna@us.ibm.com> Signed-off-by: Kelly Abuelsaad <kaymar@gmail.com>
Signed-off-by: Kelly Abuelsaad <kna@us.ibm.com> Signed-off-by: Kelly Abuelsaad <kaymar@gmail.com>
Signed-off-by: Kelly Abuelsaad <kna@us.ibm.com> Signed-off-by: Kelly Abuelsaad <kaymar@gmail.com>
Signed-off-by: Kelly Abuelsaad <kna@us.ibm.com> Signed-off-by: Kelly Abuelsaad <kaymar@gmail.com>
Signed-off-by: Kelly Abuelsaad <kna@us.ibm.com> Signed-off-by: Kelly Abuelsaad <kaymar@gmail.com>
Signed-off-by: Kelly Abuelsaad <kna@us.ibm.com> Signed-off-by: Kelly Abuelsaad <kaymar@gmail.com>
Signed-off-by: Kelly Abuelsaad <kna@us.ibm.com> Signed-off-by: Kelly Abuelsaad <kaymar@gmail.com>
Signed-off-by: Kelly Abuelsaad <kna@us.ibm.com> Signed-off-by: Kelly Abuelsaad <kaymar@gmail.com>
Signed-off-by: Kelly Abuelsaad <kna@us.ibm.com> Signed-off-by: Kelly Abuelsaad <kaymar@gmail.com>
kellyaa
force-pushed
the
slack_researcher
branch
from
163fd7a to
3075695
Compare
Signed-off-by: Kelly Abuelsaad <kaymar@gmail.com>
Signed-off-by: Kelly Abuelsaad <kaymar@gmail.com>
Signed-off-by: Kelly Abuelsaad <kaymar@gmail.com>
a2a/slack_researcher/README.md
Outdated
|
|
||
| ## Architecture | ||
|
|
||
|  |
There was a problem hiding this comment.
Was there an architecture diagram that was intended to be included?
There was a problem hiding this comment.
yup. Missed uploading it. thanks!
a2a/slack_researcher/README.md
Outdated
| | Variable Name | Description | Default Value | | ||
| |---------------|-------------|---------------| | ||
| | OPENAI_API_URL | The URL for OpenAI compatible API | `http://localhost:11434/v1` | | ||
| | OPENAI_API_KEY | The key for OpenAI compatible API | `ollama` | |
There was a problem hiding this comment.
Perhaps this is expected to be overwritten anyway with the way it's present in the .env.template and config defaults, but I'm not quite understanding the way ollama is the default here - seems like it would be a model provider or server?
There was a problem hiding this comment.
It's the API key.. using "ollama" as is definitely confusing though :) I'll update it
a2a/slack_researcher/a2a_agent.py
Outdated
| "Find tme the most popular channels for discussing AI agents", | ||
| "Summarize what's been happening in the general channel latley", |
There was a problem hiding this comment.
| "Find tme the most popular channels for discussing AI agents", | |
| "Summarize what's been happening in the general channel latley", | |
| "Find me the most popular channels for discussing AI agents", | |
| "Summarize what's been happening in the general channel lately", |
Signed-off-by: Kelly Abuelsaad <kaymar@gmail.com>
|
@kellyaa code looks good. My only concern is how this integrates with the UI component. With the existing weather agent and tools, user gets to pick which environment variables are set when the workload pods are started. These environment variables are set using a configmap here: https://github.com/kagenti/kagenti/blob/main/kagenti/installer/app/resources/environments.yaml. I'm wondering instead of creating a .env file, would it be more consistent to create a separate configmap item with default values for the new app? |
|
@huang195 That's a really good point. I'll update the environments configmap! |
Signed-off-by: Kelly Abuelsaad <kaymar@gmail.com>
|
Added config to |
Signed-off-by: Kelly Abuelsaad <kaymar@gmail.com>
Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>
Signed-off-by: Kelly Abuelsaad <kaymar@gmail.com>
Signed-off-by: Kelly Abuelsaad <kaymar@gmail.com>
Signed-off-by: Kelly Abuelsaad <kaymar@gmail.com>
|
I think the PR is ready for merge - I understand that there are still issues about how to deal with the env variables (which is a general problem in Kagenti UI) but I think we can merge this now and work on successive PRs to solve the problem. |
5 participants
Sample agent that connects to slack MCP server. Should produce decent though not perfect output, as it is more sophisticated than "hello world" but still "example grade".