fix: add retry with exponential backoff to weather MCP tool#222
Open
fix: add retry with exponential backoff to weather MCP tool#222
Conversation
The weather tool calls external Open-Meteo APIs that can timeout or return transient errors in CI environments. This caused E2E test failures across all kagenti PRs. Changes: - Use requests.Session with urllib3 Retry strategy (3 retries, exponential backoff, retry on 429/5xx) - Increase timeout from 10s to 30s (configurable via WEATHER_REQUEST_TIMEOUT) - Catch RequestException and return user-friendly error instead of crashing — lets the LLM retry the tool call gracefully - All retry params configurable via env vars (WEATHER_MAX_RETRIES, WEATHER_BACKOFF_FACTOR) Signed-off-by: Ladislav Smola <lsmola@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
requests.Sessionwithurllib3.Retrystrategy (3 retries, exponential backoff)WEATHER_REQUEST_TIMEOUT)RequestExceptionand return user-friendly message instead of crashingWEATHER_MAX_RETRIES,WEATHER_BACKOFF_FACTOR,WEATHER_REQUEST_TIMEOUTContext
The weather tool calls external Open-Meteo APIs that frequently timeout from CI runners, causing E2E test failures across ALL kagenti PRs. The tool had no error handling — any failure crashed the entire tool call.