doc(quickstart): added changes to fix the readme quickstart to generate helm charts through makefile. #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EItanya
approved these changes
Sep 22, 2025
Collaborator
EItanya
left a comment
EItanya
left a comment
There was a problem hiding this comment.
This LGTM, you need to sign your commit to pass DCO please
…te helm charts through makefile. Signed-off-by: nmaryam <30682293+nmaryam@users.noreply.github.com>
nmaryam
force-pushed
the
readme-quickstart-fix
branch
from
8efa29a to
0988ffc
Compare
antweiss
approved these changes
Sep 23, 2025
Collaborator
antweiss
left a comment
antweiss
left a comment
There was a problem hiding this comment.
Thank you for this! We move things around and forget to document that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved chart generation issues by documenting the required makefile command in README.md, preventing future users from encountering the same setup issues.