Update AgentCard.tsx #964
Merged
Update AgentCard.tsx #964
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed the squished badge issue with a ribbon Signed-off-by: Rutuj Dhawale <148652804+killjoycircuit@users.noreply.github.com>
EItanya
reviewed
Sep 29, 2025
Contributor
EItanya
left a comment
EItanya
left a comment
There was a problem hiding this comment.
Can you please post some screenshots of the fix?
wrapped comments in curly braces Signed-off-by: Rutuj Dhawale <148652804+killjoycircuit@users.noreply.github.com>
Edited comment Signed-off-by: Rutuj Dhawale <148652804+killjoycircuit@users.noreply.github.com>
peterj
reviewed
Sep 29, 2025
| <KagentLogo className="h-5 w-5 flex-shrink-0" /> | ||
| <span className="truncate">{agentRef}</span> | ||
| </CardTitle> | ||
| <div className="flex items-center space-x-2 invisible group-hover:visible"> |
Collaborator
There was a problem hiding this comment.
we want to hide the edit/delete buttons unless the user hovers over the card
peterj
reviewed
Sep 29, 2025
|
|
||
| {/* this handles the ribbon part to edit it change the py to change height and bg-yellow-400/30 to change transparency levels*/} | ||
| </div> | ||
| {!deploymentReady && ( |
Collaborator
There was a problem hiding this comment.
we should display both messages - Not accepted if the yaml/agent was not accepted and Not ready if the pod is still coming up
Contributor
Author
|
I will make those changes |
Contributor
Author
|
@peterj ,please review the ui changes as you mentioned 
|
peterj
approved these changes
Oct 9, 2025
Collaborator
|
thanks!! |
Contributor
Author
|
@peterj I just realized the PR got merged before I committed my latest UI changes. I’d made the updates and shared screenshots, but was waiting to check with you if they looked good or needed tweaks. Looks like those changes didn’t make it in I can open a new PR to fix that. |
Collaborator
|
yes, please submit another pr
…On Thu, Oct 9, 2025 at 17:15 Rutuj Dhawale ***@***.***> wrote:
*killjoycircuit* left a comment (kagent-dev/kagent#964)
<#964 (comment)>
@peterj <https://github.com/peterj> I just realized the PR got merged
before I committed my latest UI changes. I’d made the updates and shared
screenshots, but was waiting to check with you if they looked good or
needed tweaks. Looks like those changes didn’t make it in I can open a new
PR to fix that.
—
Reply to this email directly, view it on GitHub
<#964 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACURJ3EAZPM32AAMWIJFGWL3W2CZRAVCNFSM6AAAAACH2HVQ26VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTGOBWGQ3TMNJZGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Contributor
Author
|
i have submitted another pr #1011 |
jmhbh
pushed a commit
to jmhbh/kagent
that referenced
this pull request
Oct 10, 2025
Fixed the squished badge bug with a ribbon as mentioned in kagent-dev#952. The ribbon can be adjusted by changing the thickness and transparency Edit: <img width="428" height="230" alt="fix" src="https://github.com/user-attachments/assets/537b07cb-192b-4f4b-8dbe-65139c116d27" /> also i attached screenshots in kagent-dev#952 --------- Signed-off-by: Rutuj Dhawale <148652804+killjoycircuit@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the squished badge bug with a ribbon as mentioned in #952. The ribbon can be adjusted by changing the thickness and transparency
Edit:
also i attached screenshots in #952