Repository navigation
feat(auth): pass the outgoing a2a request to UpstreamAuth - #3178
Draft
codyhartsook wants to merge 1 commit into
Draft
codyhartsook wants to merge 1 commit into
codyhartsook wants to merge 1 commit into
Conversation
Signed-off-by: Cody Hartsook <cody.hartsook@solo.io>
github-actions
Bot
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
UpstreamAuth now receives the outgoing a2a request, so an AuthProvider can treat a message send differently from a read or a cancel. Providers read it with
auth.UpstreamRequestFrom(r.Context())and switch on its type, such asa2a.SendMessageRequest. The AuthProvider interface does not change.Related Issues
None required.
Testing
go test -race ./core/pkg/auth/ ./core/internal/a2agateway/TestRuntimeDialerRoutesUnaryAndStreamingCalls checks that UpstreamAuth sees each request in order: send, stream, subscribe, get and cancel.
Change Type
/kind new_feature
Changelog