Skip to content

fix(ui): serve the mock playwright suite from a production build, not the dev server #3163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Charlesthebird wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix(ui): serve the mock playwright suite from a production build, not the dev server #3163

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions ui/playwright.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,13 @@ const LIVE_COMMAND = `yarn dev --port ${LIVE_PORT}`;
/** A pre-bundle cache per server, so one server's re-optimize cannot delete another's. */
const ownCache = (port: number) => ({ KAGENT_UI_DEV_CACHE_DIR: `node_modules/.vite/e2e-${port}` });

/**
* The mock servers serve a production build, so the suite tests the bundle that ships.
* Each gets its own `outDir`, because its env pins are inlined at build time.
*/
const serveBuild = (port: number) =>
`yarn vite build --outDir dist/e2e-${port} && yarn vite preview --outDir dist/e2e-${port} --port ${port}`;

export default defineConfig({
testDir: "./playwright/tests",
// Both servers have to be rendering, not merely listening, before any test
Expand Down Expand Up @@ -220,18 +227,18 @@ export default defineConfig({
]
: [
{
command: `yarn dev --port ${PORT}`,
command: serveBuild(PORT),
url: BASE_URL,
reuseExistingServer: false,
timeout: 120_000,
env: { ...BARE_APP, ...ownCache(PORT) },
env: BARE_APP,
},
{
command: `yarn dev --port ${EXTENSION_PORT}`,
command: serveBuild(EXTENSION_PORT),
url: EXTENSION_BASE_URL,
reuseExistingServer: false,
timeout: 120_000,
env: { ...EXAMPLE_APP, ...ownCache(EXTENSION_PORT) },
env: EXAMPLE_APP,
},
],
});
Loading