Skip to content

Conversation

@syedazeez337
Copy link

Description:

This PR addresses the issue where requests to OpenAI-compatible model
services were hardcoded with "stream": false.

I have introduced a new stream configuration field to the Agent API. This gives
developers explicit control over whether they want streaming responses enabled or
disabled for their agents.

Key Changes:

   - API Update: Added an optional stream field (boolean) to the Agent spec in both
     v1alpha1 and v1alpha2.
   - Default Behavior: To ensure backward compatibility and safety, the field defaults
     to false if not specified.
   - ADK Integration: Updated the Python ADK and the translator logic to propagate
     this setting all the way down to the model runner. When enabled, it correctly
     sets the internal state to StreamingMode.SSE.
   - Documentation: Updated the Helm chart descriptions to reflect the new field.

Testing:

   - Added new Python unit tests to verify that the boolean flag correctly maps to the
     StreamingMode enum.
   - Verified that existing OpenAI model integration tests pass.
   - Updated the Go "golden files" to match the new API schema.

Everything has been linted and verified against the contribution guidelines. Let me
know if you have any questions

Fixes #1099

Copy link
Contributor

@EItanya EItanya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for the contribution, and this change definitely makes sense. The one thing i'd like to note is that I actually originally tried to make stream: true the default, but ran into issues. Have you done e2e testing with stream = true?

This adds a 'Stream' field to the Agent API (v1alpha1/v1alpha2), defaulting to false, and propagates it through the ADK and translator layers to allow enabling streaming for OpenAI-compatible model services.

Fixes kagent-dev#1099

Signed-off-by: Azeez Syed <syedazeez337@gmail.com>
@syedazeez337 syedazeez337 force-pushed the fix/issue-1099-streaming-support branch from 9557ee3 to 5ecca4a Compare December 8, 2025 17:20
@syedazeez337
Copy link
Author

syedazeez337 commented Dec 8, 2025

Hi @EItanya, I have tested and passed the e2e tests locally. Let me know if it is working now. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Agent requests OpenAI-compatible modelservice with stream set to false

2 participants