feat(models): add initial support for xAI Grok models #1128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdabasinskas
requested review from
EItanya,
ilackarms,
peterj and
yuval-k
as code owners
Signed-off-by: Tomas Dabašinskas <tomas.dabasinskas@datolabs.io>
Signed-off-by: Tomas Dabašinskas <tomas.dabasinskas@datolabs.io>
…ation Signed-off-by: Tomas Dabašinskas <tomas.dabasinskas@datolabs.io>
Signed-off-by: Tomas Dabašinskas <tomas.dabasinskas@datolabs.io>
Signed-off-by: Tomas Dabašinskas <tomas.dabasinskas@datolabs.io>
Signed-off-by: Tomas Dabašinskas <tomas.dabasinskas@datolabs.io>
Signed-off-by: Tomas Dabašinskas <tomas.dabasinskas@datolabs.io>
Signed-off-by: Tomas Dabašinskas <tomas.dabasinskas@datolabs.io>
Signed-off-by: Tomas Dabašinskas <tomas.dabasinskas@datolabs.io>
…IConfig Signed-off-by: Tomas Dabašinskas <tomas.dabasinskas@datolabs.io>
…tion Signed-off-by: Tomas Dabašinskas <tomas.dabasinskas@datolabs.io>
Signed-off-by: Tomas Dabašinskas <tomas.dabasinskas@datolabs.io>
Signed-off-by: Tomas Dabašinskas <tomas.dabasinskas@datolabs.io>
…ndling Signed-off-by: Tomas Dabašinskas <tomas.dabasinskas@datolabs.io>
…ble field handling Signed-off-by: Tomas Dabašinskas <tomas.dabasinskas@datolabs.io>
Signed-off-by: Tomas Dabašinskas <tomas.dabasinskas@datolabs.io>
Signed-off-by: Tomas Dabašinskas <tomas.dabasinskas@datolabs.io>
Signed-off-by: Tomas Dabašinskas <tomas.dabasinskas@datolabs.io>
… json tags Signed-off-by: Tomas Dabašinskas <tomas.dabasinskas@datolabs.io>
Author
|
@dmitri-d, @nlamirault, @christian-posta, any comments on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds initial support for xAI Grok models. They are OpenAI-compatible, but support some additional features.
The initial idea was to include support for these additional features, like Search Tools or Live Search in this PR, but that proven to be more complex than I anticipated. Hence, adding just initial support (same as other models) for now.
Tested the changes locally with couple of the new models - seems to be working.