feat: Add support for scheduling in agent Helm charts #1119
+168
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alpha-er
requested review from
EItanya,
ilackarms and
yuval-k
as code owners
alpha-er
force-pushed
the
feature/agent-pod-scheduling
branch
from
d0e720b to
f02e3f7
Compare
Contributor
|
Hey there, can you please update your branch with |
EItanya
previously approved these changes
Dec 10, 2025
EItanya
requested changes
Dec 10, 2025
Comment on lines
180
to
191
| {{- with .Values.nodeSelector }} | ||
| nodeSelector: | ||
| {{- toYaml . | nindent 8 }} | ||
| {{- end }} | ||
| {{- with .Values.tolerations }} | ||
| tolerations: | ||
| {{- toYaml . | nindent 8 }} | ||
| {{- end }} | ||
| {{- with .Values.affinity }} | ||
| tolerations: | ||
| {{- toYaml . | nindent 8 }} | ||
| {{- end }} |
Contributor
There was a problem hiding this comment.
Have you tested this? It has tolerations twice instead of affinities
Signed-off-by: ER Hapal <erhapal@gmail.com>
alpha-er
force-pushed
the
feature/agent-pod-scheduling
branch
from
d726e84 to
15a13a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
nodeSelector,tolerations, andaffinityin each agent template in their respective Helm charts