automatically configure logging/log level when the module loads #1115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds automatic logging configuration that executes when the kagent.core and kagent.adk modules are imported. The changes configure logging based on the LOG_LEVEL environment variable with a default of "INFO".
Key Changes:
- Added
configure_logging()function tokagent.core.__init__.pythat auto-executes on import - Added duplicate
configure_logging()function tokagent.adk._a2a.pythat also auto-executes on import - Removed the previous
configure_logging()function fromkagent.adk.cli.pyand updated imports to use the version from_a2a.py
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 8 comments.
| File | Description |
|---|---|
| python/packages/kagent-core/src/kagent/core/init.py | Adds configure_logging() function with auto-execution at module import time |
| python/packages/kagent-adk/src/kagent/adk/_a2a.py | Adds duplicate configure_logging() function with auto-execution at module import time |
| python/packages/kagent-adk/src/kagent/adk/cli.py | Removes old logging configuration and imports from _a2a module instead |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
peterj
force-pushed
the
peterj/readloglevelfromenv
branch
from
5a994c0 to
c385d33
Compare
EItanya
reviewed
Nov 24, 2025
Signed-off-by: Peter Jausovec <peter.jausovec@solo.io>
Signed-off-by: Peter Jausovec <peter.jausovec@solo.io>
Signed-off-by: Peter Jausovec <peter.jausovec@solo.io>
peterj
force-pushed
the
peterj/readloglevelfromenv
branch
from
460e25f to
e950afc
Compare
EItanya
approved these changes
Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.