Fixes #1107 infinite re-render loop in model edit page #1109
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When clicking the edit (pencil) icon on a model in the Models page, the UI enters an infinite loop causing:
• Continuous page refreshing
• Infinite API calls to /models/new?edit=true&name=...
• Unusable interface
Root Cause
The useEffect hook in ui/src/app/models/new/page.tsx had isLoading in its dependency array. Since the effect calls setIsLoading(true), it triggers itself repeatedly.
Solution
• Removed isLoading from the useEffect dependency array
• Simplified loading state logic by removing conditional check
Changes
• Modified ui/src/app/models/new/page.tsx line 206
• Effect now only runs when actual dependencies change (edit mode, model name, providers, etc.)
Testing
• Edit model functionality now loads once and remains stable
• No more infinite API calls or page refreshing
• Model data loads correctly for editing
Fixes #1107 described in the bug report where editing models caused infinite loops.