fix(task_store): update task model dump mode to 'json' in API request… #1031
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… (fixes tool call to github mcp server fails #976) Signed-off-by: Peter Jausovec <peter.jausovec@solo.io>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR ensures tasks are serialized with JSON-compatible types before being sent to the API, addressing failures when calling the GitHub MCP server (issue #976).
- Switches Task serialization to model_dump(mode="json") for API POSTs.
- Maintains existing error handling via response.raise_for_status().
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Comment on lines
28
to
+31
| Raises: | ||
| httpx.HTTPStatusError: If the API request fails | ||
| """ | ||
| response = await self.client.post("/api/tasks", json=task.model_dump()) | ||
| response = await self.client.post("/api/tasks", json=task.model_dump(mode="json")) |
There was a problem hiding this comment.
[nitpick] Consider updating the method docstring to note that the task is serialized using model_dump(mode='json') to ensure JSON-compatible types are sent to the API. This clarifies the intent for future maintainers and aligns the docs with behavior.
EItanya
approved these changes
Oct 20, 2025
This was referenced Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… (fixes tool call to github mcp server fails #976)