-
Notifications
You must be signed in to change notification settings - Fork 352
Open
Description
π Prerequisites
- I have searched the existing issues to avoid creating a duplicate
- By submitting this issue, you agree to follow our Code of Conduct
π Feature Summary
Add support for ModelConfig TLS configuration for non-openai agent
β Problem Statement / Motivation
Currently a ModelConfig's TLS config is only applied for openai providers' clients. We are missing this support for other clients (e.g. Anthropic, Gemini, Ollama).
π‘ Proposed Solution
- Investigate the other providers' clients to implement support for attaching the ca certs.
- Add TLS configuration support for the missing providers' clients, where possible.
- Add tests to validate support.
- Ensure backwards compatibility (i.e. use existing configuration if no TLS config is set).
π Alternatives Considered
No response
π― Affected Service(s)
None
π Additional Context
The config already exists on the kubernetes/go side (crd + translation), it is set on the BaseLLM, which means we just need to pass it down to other providers and configure their clients with the settings.
The original implementation PR was #1059, which includes extensive tests, so expanding on tests is hopefully not too difficult.
π Are you willing to contribute?
- I am willing to submit a PR for this feature
Metadata
Metadata
Assignees
Labels
No labels
Type
Projects
Status
Backlog