Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dnd 4.1.2 fix #85

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Dnd 4.1.2 fix #85

wants to merge 9 commits into from

Conversation

Kapuzenjoe
Copy link

restore skill/save/ability functionality in dnd 4.1.2.
However, some code cleanup is necessary and the damage critical feature does not work. (the function had not worked for me before)
There is currently no separate reminder for tools, only the one via ability. I have therefore commented out the hook for now.
Since I don't use dae, midi or rsr, I only touched on the core functionalities (as well as the midi flag reminder)

For the fix, I've focused on functionality rather than beauty. If I get the chance, I can do a little clean-up here too, if you want.

restore skill/save/ability functionality in dnd 4.1.2. However, some code cleanup is necessary and the damage critical feature does not work.
@Kapuzenjoe

This comment was marked as outdated.

@kaelad02
Copy link
Owner

kaelad02 commented Mar 3, 2025

Thanks for starting this.

The one change I'd like to make is to only process the rolls once. For example, a skill check is also an ability check and the system now calls the whole chain on a skill check. You made changes to the Reminders, for example, so they no longer call super when getting their advantage/disadvantage keys. It works but there are some downsides. First, there's a small performance hit doing this work multiple times. It might not make a measurable impact, but I'd like to avoid it if possible. The second is that it's possible to get things wrong with some edge cases where there are multiple advantage/disadvantage flags that would cancel out. They might cancel out on the Skill check hook but then advantage is applied during the Ability check hook when it should have been canceled out too.

I've got changes for that but I'd like to go over it one more time to make sure I didn't mess anything up. Hopefully later today or tomorrow I'll commit that change to this PR and then get this merged. There's some cleanup, like you called out, but I'll leave that for another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants