Change the auto-fail chat message to look like a die roll #19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original auto-fail chat message was designed to look like an item card. It used the active effect's label and icon as the header and included some text to say the roll failed. While having the active effects listed, it's the first thing that draws your eyes. Even though
automatically fails
was in bold, the message was kind of hard to read.This new version takes a different approach. The user expects to see a roll result in chat, so why not make the auto-fail chat message look more like a die roll? While we lose the information as to why the roll failed, I think it makes it up in readability. We don't show the source when making advantage the default or the message either so I don't see it as a huge loss. It seems a lot more obvious that the roll automatically failed this way.
Here's a screenshot of the before (top) and after (bottom):