Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the auto-fail chat message to look like a die roll #19

Merged
merged 10 commits into from
Feb 5, 2022

Conversation

kaelad02
Copy link
Owner

@kaelad02 kaelad02 commented Feb 4, 2022

The original auto-fail chat message was designed to look like an item card. It used the active effect's label and icon as the header and included some text to say the roll failed. While having the active effects listed, it's the first thing that draws your eyes. Even though automatically fails was in bold, the message was kind of hard to read.

This new version takes a different approach. The user expects to see a roll result in chat, so why not make the auto-fail chat message look more like a die roll? While we lose the information as to why the roll failed, I think it makes it up in readability. We don't show the source when making advantage the default or the message either so I don't see it as a huge loss. It seems a lot more obvious that the roll automatically failed this way.

Here's a screenshot of the before (top) and after (bottom):

image

@kaelad02 kaelad02 self-assigned this Feb 4, 2022
@kaelad02
Copy link
Owner Author

kaelad02 commented Feb 4, 2022

TODO have to check tests... probably need some updating there

@kaelad02 kaelad02 added the enhancement New feature or request label Feb 4, 2022
@kaelad02
Copy link
Owner Author

kaelad02 commented Feb 5, 2022

@DarKDinDoN You were looking to add localization to this original version of the failure message. I used Google Translate and came up with Échec Automatique but it wouldn't hurt to have it double-checked. Would you mind confirming/correcting that so I can include it in this PR?

@mech-tools
Copy link
Contributor

@kaelad02 "Échec automatique" is correct.
I would drop the second upper case on "automatique" tho. Just like I would for the english version.

@kaelad02 kaelad02 merged commit a35a9a0 into main Feb 5, 2022
@kaelad02 kaelad02 deleted the newFailMessage branch February 5, 2022 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants