Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Advantage on tool rolls don't work #60

Closed
kaelad02 opened this issue Feb 22, 2024 · 1 comment
Closed

Advantage on tool rolls don't work #60

kaelad02 opened this issue Feb 22, 2024 · 1 comment
Assignees
@kaelad02
Labels
bug Something isn't working

Comments

@kaelad02
Copy link
Owner

I'm not sure exactly when, but the dnd5e.preRollToolCheck changed the arguments it passes. It means that checking for advantage doesn't work anymore. I didn't test messages yet, but it might affect those too.
@kaelad02 kaelad02 added the bug Something isn't working label Feb 22, 2024
@kaelad02 kaelad02 self-assigned this Feb 22, 2024
@kaelad02
Copy link
Owner Author

Looks like it was changed back in dnd5e v2.2.0 when tool proficiencies were added to the actor.

kaelad02 added a commit that referenced this issue Feb 24, 2024
@kaelad02
Merge pull request #61 from kaelad02/fix60
ab7fe34 
Adapt to some skill and tool changes the system made, fixing #60
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kaelad02 kaelad02

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kaelad02