Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Inline Roll Commands in messages #40

Closed
MaxPat931 opened this issue Nov 3, 2022 · 2 comments
Closed

Support Inline Roll Commands in messages #40

MaxPat931 opened this issue Nov 3, 2022 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@MaxPat931
Copy link

Using /rollItem in the damage dialog I can create consumables that can add to the current roll, in a slightly roundabout way, using /rollItem to consume the charge of the item, and then the bonus damage in a regular deferred inline roll.
Could also be useful with #38 for example with Sanctuary, grant a reminder on attack rolls that has a [[/rollSave wis]] so the attacker who forgot to roll beforehand gets a prompt to do so

image

@kaelad02 kaelad02 self-assigned this Nov 3, 2022
@kaelad02
Copy link
Owner

kaelad02 commented Nov 3, 2022

TextEditor#enrichHTML, the Foundry function responsible for making the inline rolls and document links doesn't add the custom enrichers, which IRC uses, if you run the function synchronously. Changing it to async will get it to use the custom enrichers, gotta test if there's any other side effect considering all this work is done in a hook.

kaelad02 added a commit that referenced this issue Nov 3, 2022
@kaelad02
Copy link
Owner

kaelad02 commented Nov 3, 2022

Gonna add a few more updates, then I'll push a new release that'll include this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants