Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bang-pattern on applyContToValue's value argument #295

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

edmundnoble
Copy link
Collaborator

This ensures more robustly that all of the work done by an expression is done by the time it returns, though still some care is needed for the more nested Pact value types.

PR checklist:

  • Test coverage for the proposed changes
  • PR description contains example output from repl interaction or a snippet from unit test output
  • (If Relevant) Documentation has been (manually) updated at https://docs.kadena.io/pact

Additionally, please justify why you should or should not do the following:

  • Benchmark regressions
  • Confirm replay/back compat (Ignore until core release)
  • (For Kadena engineers) Run integration-tests against a Chainweb built with this version of Pact (Ignore until core release)

This ensures more robustly that all of the work done by an expression
is done by the time it returns, though still some care is needed for
the more nested Pact value types.
@edmundnoble edmundnoble merged commit d26b479 into master Dec 23, 2024
10 checks passed
@edmundnoble edmundnoble deleted the push-rskpzpyvxyus branch December 23, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants