docs: update benchmarks and docs for encryption at rest#82
Merged
Conversation
compares persistence throughput with and without AES-256-GCM encryption. runs two ember instances (plaintext vs encrypted) and reports side-by-side results with overhead percentages.
- bench/README.md: encryption overhead section, script entry, build note - README.md: encryption feature, config flag, quickstart example, test count 886 → 906, security note - ember-persistence/README.md: encryption module, v3 format docs - ember-server/README.md: encryption example with feature flag - SECURITY.md: encryption at rest section with key management guidance
- benchmark.rs: use `is_ascii_lowercase()` instead of manual range check - cluster.rs: use `(0..16384).contains()` instead of manual comparison
kacy
added a commit
that referenced
this pull request
Feb 11, 2026
* bench: add encryption overhead benchmark script compares persistence throughput with and without AES-256-GCM encryption. runs two ember instances (plaintext vs encrypted) and reports side-by-side results with overhead percentages. * docs: update benchmarks and docs for encryption at rest - bench/README.md: encryption overhead section, script entry, build note - README.md: encryption feature, config flag, quickstart example, test count 886 → 906, security note - ember-persistence/README.md: encryption module, v3 format docs - ember-server/README.md: encryption example with feature flag - SECURITY.md: encryption at rest section with key management guidance * fix: resolve clippy warnings for range contains patterns - benchmark.rs: use `is_ascii_lowercase()` instead of manual range check - cluster.rs: use `(0..16384).contains()` instead of manual comparison
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
bench/bench-encryption.sh— a focused benchmark script that compares persistence throughput with and without AES-256-GCM encryption, following existing script patternswhat was tested
bash -n bench/bench-encryption.shpasses syntax check--encryption-key-fileflag in the serverdesign considerations
the benchmark script runs two ember instances side-by-side (plaintext vs encrypted) on different ports with temp data dirs and a random key file, cleaned up on exit. results tables in bench/README.md are left as placeholders to be filled after running on a dedicated VM — didn't want to include local laptop numbers that won't be reproducible.