feat: improve graceful shutdown drain visibility#263
Merged
Conversation
log active connection count when drain starts and remaining count if the 30s timeout expires, giving operators visibility into shutdown progress.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
improves the
drain_connectionsfunction to log the active connection count when shutdown begins and the remaining connection count if the 30-second timeout expires. this gives operators better visibility into shutdown progress — previously the logs only said "waiting for connections..." with no count, and "timeout" with no indication of how many connections were stuck.also reviewed the full shutdown path for both concurrent and threaded modes. both are solid:
drain_connections(30s timeout) → exitrt.shutdown_timeout(30s)per worker → join threadsno behavioral changes, just better observability during shutdown.
what was tested
cargo test -p ember-server— all 137 tests passcargo check -p ember-server— clean compiledesign considerations
kept the change minimal — the drain timeout and semaphore-based mechanism are already correct. the only gap was that operators couldn't see how many connections were active or stuck during shutdown. the
saturating_subon available permits gives an accurate count since each connection holds exactly one permit.