Merged
Conversation
remove all --skip filters from CI and run the full integration test suite (79 tests including 29 cluster and 7 CLI tests). two changes make this reliable: - deterministic port allocation for cluster servers: a PID-seeded atomic counter hands out blocks of 3 consecutive ports (data, gossip, raft), eliminating the race between find_free_port() and the server binding its cluster ports. - --test-threads=2 for integration tests: each cluster test spawns 1-3 ember-server subprocesses with tokio runtimes, raft, and gossip. more than 2 concurrent tests causes resource contention and connection resets on shared CI runners. unit tests are split into a separate step so they still run at full parallelism.
This was referenced Feb 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
removes all
--skipfilters from CI, enabling the full integration test suite:the cluster wiring was already complete — these tests were skipped during
development and never re-enabled.
what changed
tests/integration/src/helpers.rs— deterministic port allocation forcluster-enabled test servers. a PID-seeded atomic counter hands out blocks of
3 consecutive ports (data, gossip at +1, raft at +2), preventing the race
between OS port assignment and server binding that caused flaky "connection
reset by peer" failures under parallel execution.
.github/workflows/ci.yml— split the test step into:unit tests: runs all workspace crate tests at full parallelismintegration tests: runs the subprocess-based integration suite with--test-threads=2(each test spawns 1-3 ember-server processes, so higherparallelism causes resource contention on CI runners)
what was tested
cargo build --workspace --features protobuf,grpc— cleancargo test --workspace --features protobuf,grpc --exclude ember-integration-tests— 387+ unit tests passcargo test -p ember-integration-tests --test integration -- --test-threads=2— all 79 integration tests pass, stable across repeated runscargo clippy --workspace --features protobuf,grpc -- -D warnings— cleancargo fmt --all --check— cleandesign considerations
considered higher thread counts (4, 8) but they produce intermittent failures
from resource contention when ~50 ember-server subprocesses run simultaneously.
--test-threads=2is the sweet spot — reliable while keeping total integrationtest time under 10 seconds.