harden: replace unmaintained dep, enable overflow checks#101
Merged
Conversation
- replace rustls-pemfile (RUSTSEC-2025-0134) with rustls-pki-types PemObject trait — pem parsing now happens in constant time for private key data - enable overflow-checks = true in release profile so integer overflows panic instead of silently wrapping - update all dependencies to latest compatible versions - cargo audit now reports zero advisories
kacy
added a commit
that referenced
this pull request
Feb 19, 2026
…101) - replace rustls-pemfile (RUSTSEC-2025-0134) with rustls-pki-types PemObject trait — pem parsing now happens in constant time for private key data - enable overflow-checks = true in release profile so integer overflows panic instead of silently wrapping - update all dependencies to latest compatible versions - cargo audit now reports zero advisories
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
rustls-pemfile(RUSTSEC-2025-0134, unmaintained) withrustls-pki-typesPemObject trait — PEM parsing now happens in constant time for private key dataoverflow-checks = truein release profile so integer overflows panic instead of silently wrapping in productioncargo auditnow reports zero advisorieswhat was tested
cargo audit— zero advisoriescargo test --workspace --features protobuf— all tests passcargo clippy --workspace --features protobuf -- -D warnings— cleandesign considerations
the
rustls-pki-typescrate was already a transitive dependency throughrustls 0.23. switching to its PemObject trait is a straightforward migration — the API is nearly identical but PEM parsing of private key material now uses constant-time operations internally.enabling overflow checks in release mode is a conscious tradeoff: a tiny performance cost (~1-2% on arithmetic-heavy paths) in exchange for crash-on-overflow rather than silent-wrap-to-wrong-value. for a database, crashing is strictly preferable to corrupting data silently.