Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

103 webcomponents #2

Merged
merged 21 commits into from
Dec 14, 2021
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add comment
  • Loading branch information
frdsndr committed Dec 14, 2021
commit 711fb15b4c499708cd35b30e9847f6481bcd1da1
3 changes: 2 additions & 1 deletion src/components/navBar.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ class Navigation extends HTMLElement {
img.setAttribute('class', 'logo-kaboom');
img.setAttribute('alt', 'Kaboom Shebang');

// instead of using a template you can also just append directly to the shadowDOM
// append link and image to the nav element
nav.appendChild(link);
link.appendChild(img);
Expand All @@ -45,7 +46,7 @@ class Navigation extends HTMLElement {

// attach the styles to the shadow dom
shadow.appendChild(style);
// attach the top element to the shadow dom
// and finally, attach the top element to the shadow dom
shadow.appendChild(nav);
}
}
Expand Down