Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate tools in Go modules #681

Merged
merged 1 commit into from
May 31, 2022
Merged

Separate tools in Go modules #681

merged 1 commit into from
May 31, 2022

Conversation

ccremer
Copy link
Contributor

@ccremer ccremer commented May 31, 2022

Summary

To remove it from the main go.mod file, which would introduce unnecessary
dependency for other modules importing K8up code.

Renovate should still make PRs for those tools.

Checklist

  • Keep pull requests small so they can be easily reviewed.
  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking,
    as they show up in the changelog
  • Update the documentation.
  • Update tests.
  • Link this PR to related issues.

@ccremer ccremer added the change Generic change that is neither a fix or feature label May 31, 2022
@ccremer ccremer force-pushed the tools branch 2 times, most recently from bbf4a69 to 3fcdf55 Compare May 31, 2022 13:27
To remove them from the main go.mod file, which would introduce unnecessary 
dependency for other modules importing K8up code.

Renovate should still make PRs for those tools.

Signed-off-by: Chris <github.account@chrigel.net>
@ccremer ccremer marked this pull request as ready for review May 31, 2022 13:46
@ccremer ccremer requested a review from a team as a code owner May 31, 2022 13:46
@ccremer ccremer requested review from simu, bastjan and Kidswiss and removed request for a team, simu and bastjan May 31, 2022 13:46
Copy link
Contributor

@Kidswiss Kidswiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ccremer ccremer merged commit d50e9d9 into master May 31, 2022
@ccremer ccremer deleted the tools branch May 31, 2022 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change Generic change that is neither a fix or feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants