Ensure https is shown in code block in tutorial #661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks like I don't have enough rights to set a label. The label should be |
|
@chloesoe Can you amend your commit so that DCO passes? |
ccremer
changed the title
chloesoe
force-pushed
the
fix-url-to-apply-crd
branch
from
68be311 to
2f2e7a9
Compare
Having it without `\https` it will be rendered as a link and not showing `https://` which leads to errors when copy pasting. Signed-off-by: Daniel Hauswirth <info@chloesoe.ch> Signed-off-by: chloesoe <info@chloesoe.ch>
chloesoe
force-pushed
the
fix-url-to-apply-crd
branch
from
2f2e7a9 to
a215609
Compare
ccremer
approved these changes
May 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Having an URL in a code block without
\httpswill be rendered as a link in a browser and not showinghttps://; thias leads to errors when copy pasting to the CLI while running the tutorial.Checklist
bug,enhancement,documentation,change,breaking,as they show up in the changelog