-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARM64 K8up #510
ARM64 K8up #510
Conversation
Do we really need ARM for local testing and building and e2e? Why not just build the images with goreleaser upon releases? |
Also, the Dockerfile needs to download the restic binary from GH release page: https://github.com/restic/restic/releases Generally I think supporting ARM is on a best-effort basis. I wouldn't yet worry about local builds and tests, just making the images released with goreleaser upon Git pushes would be fine, nothing else. |
Good catch! I've opened restic/restic#3516. It would probably not be a huge deal to refactor the restic Dockerfile and Docker image build process to produce ARM64 images.
Yes.
Would be fine by me :) |
027849a
to
8880eba
Compare
I think this is a good idea to provide ARM images, this helps people using Raspis and ARM also get's used more and more in the cloud... |
Since it is not likely that Restic provides ARM64 Docker images in the foreseeable future.
Co-authored-by: Tobias Brunner <tobias.brunner@vshn.ch>
426f0ad
to
5f0e3b8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good now 🎉
Would be interesting if that actually works.
@bastjan don't you have an ARM machine where you could quickly test it out?
I believe |
I do! I'll test it quickly... |
Works on my machine™️ |
Summary
This has no prio. But I hoped it would be a low hanging fruit.
The aim of this PR is to provide ARM64 binaries and Docker images for K8up.
Todo:
Build & Push ARM64 release Docker images with goreleaserBuild ARM64 snapshot images withmake docker-build
(see.github/workflows/master.yml
)evtl. automated test on ARM64 systemChecklist
bug
,enhancement
,documentation
,change
,breaking
,as they show up in the changelog