Fix the device spec file creation in rdma exclusive mode #611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when using exclusive mode in RDMA if we restart the device plugin it will find the right rdma device if the device is allocated. this change makes the file creation when we get a new allocation and not in the device plugin initialization Signed-off-by: Sebastian Sch <sebassch@gmail.com>
|
Hi @e0ne @ykulazhenkov @rollandf @zeeke can you please take a look on this fix please? |
Pull Request Test Coverage Report for Build 12231919857Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when using exclusive mode in RDMA if we restart the device plugin it will find the right rdma device if the device is allocated.
this change makes the file creation when we get a new allocation and not in the device plugin initialization