Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/add config #1

Merged
merged 3 commits into from
May 23, 2023
Merged

Feat/add config #1

merged 3 commits into from
May 23, 2023

Conversation

matthisholleville
Copy link
Collaborator

Closes #

📑 Description

As mentioned here : k8sgpt-ai/k8sgpt#449 & k8sgpt-ai/k8sgpt-operator#113, this pull request adds two important updates to the existing codebase.

  1. Documentation Update:

    • Added detailed documentation for the config.v1 module, which includes information about the new ConfigRequest, Cache, and ConfigResponse objects.
    • Explained the purpose and usage of the Config method in the Server service, providing an example usage as well.
    • Updated the overall documentation to include the new configuration-related information.
  2. Proto Definition Update:

    • Added the config.v1 module, which contains the definition of the ConfigRequest, Cache, and ConfigResponse messages.
    • Included a new Config method in the Server service, allowing clients to configure the system.
    • The ConfigResponse message now includes a status field to indicate the success or failure of the configuration operation.

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

ℹ Additional Information

Signed-off-by: Matthis Holleville <matthish29@gmail.com>
Signed-off-by: Matthis Holleville <matthish29@gmail.com>
Signed-off-by: Matthis Holleville <matthish29@gmail.com>
@matthisholleville matthisholleville merged commit bee8cea into main May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant