Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: the overall optimization and architecture design of the makefile are made #317

Merged
merged 3 commits into from
Apr 21, 2023
Merged

feat: the overall optimization and architecture design of the makefile are made #317

merged 3 commits into from
Apr 21, 2023

Conversation

cubxxw
Copy link
Contributor

@cubxxw cubxxw commented Apr 21, 2023 •
edited
Loading

feat: the overall optimization and architecture design of the makefile are made

Closes #305

📑 Description

Read the proposal #305 for the Makefile design

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

ℹ Additional Information

image

This will give you more information at build time:

❯ make build
go version go1.20 linux/amd64
===========> Building binary /root/workspaces/k8sgpt/bin/k8sgpt *[Git Info]: v0.2.4-13b2a1314f59d2a15a159a622c07596af22ffa31

@cubxxw cubxxw requested review from a team as code owners April 21, 2023 16:29
@cubxxw cubxxw changed the title feature(makefile): The overall optimization and architecture design of the Makefile are made feat(makefile): The overall optimization and architecture design of the Makefile are made Apr 21, 2023
@cubxxw cubxxw changed the title feat(makefile): The overall optimization and architecture design of the Makefile are made feat: The overall optimization and architecture design of the Makefile are made Apr 21, 2023
@cubxxw cubxxw changed the title feat: The overall optimization and architecture design of the Makefile are made feat: the overall optimization and architecture design of the makefile are made Apr 21, 2023
cubxxw added 2 commits April 22, 2023 00:45
@cubxxw
feature(makefile): The overall optimization and architecture design o…
4a88448 
…f the Makefile are made

Signed-off-by: Xinwei Xiong(cubxxw) <3293172751nss@gmail.com>
@cubxxw
feat: the overall optimization and architecture design of the makefil…
a3f4960 
…e are made

Signed-off-by: Xinwei Xiong(cubxxw) <3293172751nss@gmail.com>
@cubxxw cubxxw force-pushed the feat/makefile-supre branch from 898c824 to a3f4960 Compare April 21, 2023 16:47
matthisholleville
matthisholleville reviewed Apr 21, 2023
View reviewed changes
Copy link
Contributor

@matthisholleville matthisholleville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good job @cubxxw ! Left 1 comment, can't wait to hear what you think

@matthisholleville
Copy link
Contributor

Hey, I noticed that you ticked the boxes:

  • My code requires changes to the documentation
  • I have updated the documentation as required

But I'm not seeing any changes in the documentation. Is everything cool or am I missing something?

@cubxxw
Copy link
Contributor Author

cubxxw commented Apr 21, 2023

Hey, I noticed that you ticked the boxes:

  • My code requires changes to the documentation
  • I have updated the documentation as required

But I'm not seeing any changes in the documentation. Is everything cool or am I missing something?

Forgive me, I expect to find an opportunity to update later

I would like to know how to deal with the copyright, which will affect my next work

AlexsJones
AlexsJones approved these changes Apr 21, 2023
View reviewed changes
Copy link
Member

@AlexsJones AlexsJones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a a super duper contribution, thank you!

@AlexsJones AlexsJones merged commit 754bf91 into k8sgpt-ai:main Apr 21, 2023
@github-actions github-actions bot mentioned this pull request Apr 21, 2023
Merged
@cubxxw cubxxw deleted the feat/makefile-supre branch April 22, 2023 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthisholleville matthisholleville matthisholleville left review comments

@AlexsJones AlexsJones AlexsJones approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Backlog
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feature: Provide a better development experience
3 participants
@cubxxw @matthisholleville @AlexsJones