Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: envs to initialise server #281

Merged
merged 1 commit into from
Apr 15, 2023
Merged

feat: envs to initialise server #281

merged 1 commit into from
Apr 15, 2023

Conversation

AlexsJones
Copy link
Member

@AlexsJones AlexsJones commented Apr 15, 2023 •
edited
Loading

Closes #
#265

📑 Description

This checks the envs for starting a server to allow this to run in K8s

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

ℹ Additional Information

@AlexsJones
feat: envs to initialise server
0071e25 
Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
@AlexsJones AlexsJones requested review from a team as code owners April 15, 2023 11:27
arbreezy
arbreezy approved these changes Apr 15, 2023
View reviewed changes
Copy link
Member

@arbreezy arbreezy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlexsJones AlexsJones merged commit f20c139 into main Apr 15, 2023
@AlexsJones AlexsJones deleted the feat/server-envs branch April 15, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arbreezy arbreezy arbreezy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Backlog
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexsJones @arbreezy