Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix Slack link #253

Merged
merged 3 commits into from
Apr 14, 2023
Merged

Conversation

harshit-mehtaa
Copy link
Contributor

@harshit-mehtaa harshit-mehtaa commented Apr 12, 2023

Fixes issue #232

πŸ“‘ Description

  • Updated Slack link
  • Fixed missing <details> closure in README.md

βœ… Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

@harshit-mehtaa harshit-mehtaa requested review from a team as code owners April 12, 2023 14:25
@harshit-mehtaa harshit-mehtaa changed the title docs: Fix Slack link docs: fix Slack link Apr 12, 2023
Signed-off-by: Harshit Mehta <harshitm@nvidia.com>
Copy link
Contributor

@thschue thschue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this is future-proof ... @AlexsJones: WDYT?

Copy link
Contributor

@thschue thschue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently not sure if this is the way to go ...

@harshit-mehtaa
Copy link
Contributor Author

harshit-mehtaa commented Apr 12, 2023

Isn't there a generic link that can be used here?

@matthisholleville
Copy link
Contributor

Maybe we can change the Slack configuration? Currently the link does not allow new people to join. Could this be an intermediate solution?

@harshit-mehtaa
Copy link
Contributor Author

That should be the permanent solution to this

@AlexsJones
Copy link
Member

Is there a way I can allow auto joins?

@AlexsJones
Copy link
Member

Approving until we have a better solution

@AlexsJones AlexsJones merged commit b726e1e into k8sgpt-ai:main Apr 14, 2023
@harshit-mehtaa harshit-mehtaa deleted the docs/issue-232 branch April 14, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants