-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add anonymize option #242
Merged
AlexsJones
merged 12 commits into
k8sgpt-ai:main
from
matthisholleville:feature/add-anonymize-option
Apr 12, 2023
Merged
feat: add anonymize option #242
AlexsJones
merged 12 commits into
k8sgpt-ai:main
from
matthisholleville:feature/add-anonymize-option
Apr 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthis Holleville <matthish29@gmail.com>
Signed-off-by: Matthis Holleville <matthish29@gmail.com>
Signed-off-by: Matthis Holleville <matthish29@gmail.com>
matthisholleville
changed the title
Feature/add anonymize option
feat: add anonymize option
Apr 10, 2023
Signed-off-by: Matthis Holleville <matthish29@gmail.com>
matthisholleville
force-pushed
the
feature/add-anonymize-option
branch
from
April 10, 2023 21:44
8c13c8f
to
705d2a0
Compare
AlexsJones
requested changes
Apr 11, 2023
AlexsJones
reviewed
Apr 11, 2023
AlexsJones
reviewed
Apr 11, 2023
AlexsJones
reviewed
Apr 11, 2023
Signed-off-by: Matthis Holleville <matthish29@gmail.com>
I just modified the PR with all your comments @AlexsJones |
Signed-off-by: Matthis Holleville <matthish29@gmail.com>
matthisholleville
force-pushed
the
feature/add-anonymize-option
branch
from
April 11, 2023 11:42
a010afa
to
b687473
Compare
AlexsJones
reviewed
Apr 11, 2023
Signed-off-by: Matthis Holleville <matthish29@gmail.com>
ivan-valkov
reviewed
Apr 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was just checking out the repo and decided to do a quick drive by review, feel free to ignore, as long as @AlexsJones is happy with the PR :)
Thank you for your review @ivan-valkov . PR updated π |
LGTM |
Signed-off-by: Matthis Holleville <matthish29@gmail.com>
matthisholleville
force-pushed
the
feature/add-anonymize-option
branch
from
April 11, 2023 17:13
2026695
to
08f2a89
Compare
AlexsJones
approved these changes
Apr 11, 2023
Signed-off-by: Matthis Holleville <matthish29@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
π Description
Add
anonymize
option during explain.β Checks
βΉ Additional Information
As mentionned here #139, during the
analyze --explain
the data sent to the AI backend may contain sensitive information that the user wants to anonymize. A flag has been added to allow anonymization of the data before sending it to OpenAI. If an anonymized data is returned in the solution, it is de-anonymized to make the message clear for the user.