feat: store config in XDG conform location #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickpichler
force-pushed
the
feature/235/use-xdg-config-home
branch
from
674f032 to
3118abf
Compare
patrickpichler
changed the title
patrickpichler
force-pushed
the
feature/235/use-xdg-config-home
branch
from
3118abf to
b25294a
Compare
patrickpichler
changed the title
patrickpichler
changed the title
patrickpichler
force-pushed
the
feature/235/use-xdg-config-home
branch
from
b25294a to
0601402
Compare
arbreezy
reviewed
Apr 10, 2023
AlexsJones
requested changes
Apr 11, 2023
|
Thanks for updating @patrickpichler I think we need some conflicts sorted and the DCO signed -cheers! |
|
Hey @patrickpichler thanks again, is this ready for review? |
The config file is now located in an folder according to the XDG specification (`XDG_CONFIG_HOME`). Migration is performed automatically. This fixes k8sgpt-ai#235. Signed-off-by: Patrick Pichler <git@patrickpichler.dev>
patrickpichler
force-pushed
the
feature/235/use-xdg-config-home
branch
from
528a0e9 to
dee4355
Compare
|
@AlexsJones it is now ready to review 🙂 |
Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
AlexsJones
approved these changes
Apr 16, 2023
There was a problem hiding this comment.
Works beautifully, thank you
❯ go run main.go filter list
go: downloading github.com/adrg/xdg v0.4.0
Performing config file migration from `/Users/alex/.k8sgpt.yaml` to `/Users/alex/Library/Application Support/k8sgpt/k8sgpt.yaml`
Active:
> StatefulSet
> NetworkPolicy
> Node
> Service
> Ingress
> PersistentVolumeClaim
> CronJob
> ReplicaSet
> Pod
> Deployment
> VulnerabilityReport (integration)
Unused:
> PodDisruptionBudget
> HorizontalPodAutoScaler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #235
📑 Description
The config file is now located in an folder according to the XDG
specification (
XDG_CONFIG_HOME).Since this is a breaking change, there is a check in place, which
informs the end user to please migrate to the new config location, if
the a file at the old config path has been located.
✅ Checks
ℹ Additional Information
The config location will change. There is a check in place, which will display a warning to the end user.