Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deployment images must use canonical names #42

Merged
merged 2 commits into from
Jul 18, 2023
Merged

Deployment images must use canonical names #42

merged 2 commits into from
Jul 18, 2023

Conversation

daper
Copy link
Contributor

@daper daper commented Jul 17, 2023

No description provided.

@sp-yduck
Copy link
Collaborator

sp-yduck commented Jul 18, 2023 •
edited
Loading

Thank you for the PR !
could you also updates here as well ?
https://github.com/sp-yduck/cluster-api-provider-proxmox/blob/main/templates/cluster-template.yaml#L231
this image is for CCM in the workload cluster.

@daper
Copy link
Contributor Author

daper commented Jul 18, 2023

I have updated that as well, but I think that was fine as it is the cluster-api provider contract who enforces it only.

@sp-yduck
Copy link
Collaborator

I see. anyways it's better to use canonical name. thank you !

@sp-yduck sp-yduck merged commit 76dd4fa into k8s-proxmox:main Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daper @sp-yduck