Skip to content
This repository has been archived by the owner on Aug 22, 2022. It is now read-only.

[mopidy] Add new chart #1616

Merged
merged 4 commits into from
Jun 13, 2022
Merged

Conversation

lanquarden
Copy link
Contributor

Signed-off-by: lanquarden lanquarden@gmail.com

Description of the change

Adding mopidy chart

Benefits

Easily run a mopidy instance in your cluster

Possible drawbacks

It's a official container from the Iris project (web frontend), but it is not following semver, they just update the latest tag with every release of the web frontend. I think that I'll probably end up creating a headless container and a one with the frontend where the different plugins to install are configurable.

Applicable issues

  • fixes #

Additional information

The same as for the snapcast chart, bare bones helm that was tested manually with a helm install. s I learn how to successfully deploy this together with a snapcast chart I'll try to find a way to poor that back into the documentation/values.yaml

Checklist

  • Title of the PR starts with chart name (e.g. [home-assistant])
  • Chart version bumped in Chart.yaml according to semver.
  • Chart artifacthub.io/changes changelog annotation has been updated in Chart.yaml. See Artifact Hub documentation for more info.
  • Variables have been documented in the values.yaml file.

Signed-off-by: lanquarden <lanquarden@gmail.com>
@ghost ghost added size/L Categorises a PR that changes 100-499 lines, ignoring generated files. precommit:ok CI status: pre-commit validation successful changelog:ok CI status: changelog validation successful labels Jun 9, 2022
@truxnell truxnell closed this Jun 10, 2022
@truxnell truxnell reopened this Jun 10, 2022
@truxnell truxnell closed this Jun 10, 2022
@truxnell truxnell reopened this Jun 10, 2022
@ghost ghost added lint:ok CI status: linting successful install:failed CI status: install failed labels Jun 10, 2022
@truxnell
Copy link
Member

Hi @lanquarden
Thanks for the PR! Looks like it is failing install with default config, can you have a look?
Ideally our charts will pass CI for a basic install without erroring.

Signed-off-by: lanquarden <lanquarden@gmail.com>
@lanquarden
Copy link
Contributor Author

I hope latest commit fixes the although I can't trigger the CI

@ghost ghost added install:ok CI status: install successful and removed install:failed CI status: install failed labels Jun 11, 2022
Copy link
Member

@truxnell truxnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor linting changes

version: 0.0.1
kubeVersion: ">=1.16.0-0"
keywords:
- mopidy
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- mopidy
- mopidy

home: https://github.com/k8s-at-home/charts/tree/master/charts/stable/mopidy
icon: https://mopidy.org/icon
sources:
- https://github.com/mopidy/mopidy-docker
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- https://github.com/mopidy/mopidy-docker
- https://github.com/mopidy/mopidy-docker

Comment on lines 14 to 15
- name: lanquarden
email: lanquarden@gmail.com
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- name: lanquarden
email: lanquarden@gmail.com
- name: lanquarden
email: lanquarden@gmail.com

Comment on lines 17 to 19
- name: common
repository: https://library-charts.k8s-at-home.com
version: 4.4.2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- name: common
repository: https://library-charts.k8s-at-home.com
version: 4.4.2
- name: common
repository: https://library-charts.k8s-at-home.com
version: 4.4.2

Signed-off-by: lanquarden <lanquarden@gmail.com>
@lanquarden
Copy link
Contributor Author

Updated indent for yaml lists, did same update in the template

@truxnell
Copy link
Member

@lanquarden Awesome, ta

I forgot in the review - you can (like im just writing in the snapcast chart) use appVersion: latest in the Chart.yaml and then leave tag: as blank in the values.yaml
The vaules.yaml inherits from the Chart.yaml appversion (thats what # @default -- chart.appVersion does). This saves you having to update both tags if you chose to keep images bumped in the helm - you can just bump in chart only.

Signed-off-by: lanquarden <lanquarden@gmail.com>
@lanquarden
Copy link
Contributor Author

I think I got it all, latest in Chart, no tag in values.yaml in both PRs

@truxnell truxnell merged commit da002fd into k8s-at-home:master Jun 13, 2022
@truxnell
Copy link
Member

Thanks for the PR!

@all-contributors can you please add @lanquarden for code

@allcontributors
Copy link
Contributor

@truxnell

I've put up a pull request to add @lanquarden! 🎉

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
changelog:ok CI status: changelog validation successful install:ok CI status: install successful lint:ok CI status: linting successful precommit:ok CI status: pre-commit validation successful size/L Categorises a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants